2021-03-18 15:53:41

by Johan Hovold

Subject: [PATCH 4/7] USB: cdc-acm: drop redundant driver-data reset

There's no need to clear the interface driver data on failed probe (and
driver core will clear it anyway).

Signed-off-by: Johan Hovold <[email protected]>
---
drivers/usb/class/cdc-acm.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 36dd1e05e455..682772b8a4f7 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -1515,7 +1515,6 @@ static int acm_probe(struct usb_interface *intf,
}
device_remove_file(&acm->control->dev, &dev_attr_bmCapabilities);
alloc_fail5:
- usb_set_intfdata(intf, NULL);
for (i = 0; i < ACM_NW; i++)
usb_free_urb(acm->wb[i].urb);
alloc_fail4:
--
2.26.2

2021-03-22 09:42:28

by Oliver Neukum

Subject: Re: [PATCH 4/7] USB: cdc-acm: drop redundant driver-data reset

Am Donnerstag, den 18.03.2021, 16:51 +0100 schrieb Johan Hovold:
> There's no need to clear the interface driver data on failed probe (and
> driver core will clear it anyway).
>
> Signed-off-by: Johan Hovold <[email protected]>
Acked-by: Oliver Neukum <[email protected]>