2021-03-23 01:47:29

by Jiabing Wan

Subject: [PATCH] drivers: watchdog: Remove duplicate include of kernel.h

linux/kernel.h has been included at line 17, so remove the
duplicate one at line 22.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/watchdog/dw_wdt.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
index 32d0e1781e63..b1642e2d9175 100644
--- a/drivers/watchdog/dw_wdt.c
+++ b/drivers/watchdog/dw_wdt.c
@@ -19,7 +19,6 @@
#include <linux/delay.h>
#include <linux/err.h>
#include <linux/io.h>
-#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/moduleparam.h>
#include <linux/interrupt.h>
--
2.25.1

2021-03-23 02:16:12

by Guenter Roeck

Subject: Re: [PATCH] drivers: watchdog: Remove duplicate include of kernel.h

On 3/22/21 6:43 PM, Wan Jiabing wrote:
> linux/kernel.h has been included at line 17, so remove the
> duplicate one at line 22.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> drivers/watchdog/dw_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
> index 32d0e1781e63..b1642e2d9175 100644
> --- a/drivers/watchdog/dw_wdt.c
> +++ b/drivers/watchdog/dw_wdt.c
> @@ -19,7 +19,6 @@
> #include <linux/delay.h>
> #include <linux/err.h>
> #include <linux/io.h>
> -#include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/moduleparam.h>
> #include <linux/interrupt.h>
>

The reason for the duplicate include is the non-alphabetic order of include
files. I find that worse than the duplicate include. If it is too much effort
to reorder include files to be in alphabetic order, please at least don't
make it worse and remove the other include.

Guenter