2021-03-23 03:25:55

by Jiabing Wan

Subject: [PATCH] mm: process_vm_access: Remove duplicate include of compat.h

linux/compat.h has been included at line 8.So we remove
the duplicate one at line 12.

Signed-off-by: Wan Jiabing <[email protected]>
---
mm/process_vm_access.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/mm/process_vm_access.c b/mm/process_vm_access.c
index f5fee9cf90f8..4bcc11958089 100644
--- a/mm/process_vm_access.c
+++ b/mm/process_vm_access.c
@@ -9,7 +9,6 @@
#include <linux/mm.h>
#include <linux/uio.h>
#include <linux/sched.h>
-#include <linux/compat.h>
#include <linux/sched/mm.h>
#include <linux/highmem.h>
#include <linux/ptrace.h>
--
2.25.1

2021-03-23 06:35:22

by Miaohe Lin

Subject: Re: [PATCH] mm: process_vm_access: Remove duplicate include of compat.h

On 2021/3/23 11:23, Wan Jiabing wrote:
> linux/compat.h has been included at line 8.So we remove
> the duplicate one at line 12.
>

line 12 one is added via eb351d75ce1e ("mm/process_vm_access.c: include compat.h") to fix the build error:
mm/process_vm_access.c:277:5: error: implicit declaration of function 'in_compat_syscall'; did you mean 'in_ia32_syscall'? [-Werror=implicit-function-declaration]

There might be something wrong.

> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> mm/process_vm_access.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/process_vm_access.c b/mm/process_vm_access.c
> index f5fee9cf90f8..4bcc11958089 100644
> --- a/mm/process_vm_access.c
> +++ b/mm/process_vm_access.c
> @@ -9,7 +9,6 @@
> #include <linux/mm.h>
> #include <linux/uio.h>
> #include <linux/sched.h>
> -#include <linux/compat.h>
> #include <linux/sched/mm.h>
> #include <linux/highmem.h>
> #include <linux/ptrace.h>
>