2021-03-27 09:57:37

by chenlifu

Subject: [PATCH -next] i2c: gpio: use DEFINE_SPINLOCK() for spinlock

From: Lifu Chen <[email protected]>

spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Lifu Chen <[email protected]>
---
arch/arm/mach-sa1100/simpad.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm/mach-sa1100/simpad.c b/arch/arm/mach-sa1100/simpad.c
index c7fb9a73e4c5..c183432880d3 100644
--- a/arch/arm/mach-sa1100/simpad.c
+++ b/arch/arm/mach-sa1100/simpad.c
@@ -45,7 +45,7 @@
*/

static long cs3_shadow;
-static spinlock_t cs3_lock;
+static DEFINE_SPINLOCK(cs3_lock);
static struct gpio_chip cs3_gpio;

long simpad_get_cs3_ro(void)
@@ -379,8 +379,6 @@ static int __init simpad_init(void)
{
int ret;

- spin_lock_init(&cs3_lock);
-
cs3_gpio.label = "simpad_cs3";
cs3_gpio.base = SIMPAD_CS3_GPIO_BASE;
cs3_gpio.ngpio = 24;

2021-04-01 03:40:31

by chenlifu

Subject: Re: [PATCH -next] i2c: gpio: use DEFINE_SPINLOCK() for spinlock

Kindly pinging ...

Best Regards,
Chen Lifu

?? 2021/3/27 17:52, Chen Lifu д??:
> From: Lifu Chen <[email protected]>
>
> spinlock can be initialized automatically with DEFINE_SPINLOCK()
> rather than explicitly calling spin_lock_init().
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Lifu Chen <[email protected]>
> ---
> arch/arm/mach-sa1100/simpad.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-sa1100/simpad.c b/arch/arm/mach-sa1100/simpad.c
> index c7fb9a73e4c5..c183432880d3 100644
> --- a/arch/arm/mach-sa1100/simpad.c
> +++ b/arch/arm/mach-sa1100/simpad.c
> @@ -45,7 +45,7 @@
> */
>
> static long cs3_shadow;
> -static spinlock_t cs3_lock;
> +static DEFINE_SPINLOCK(cs3_lock);
> static struct gpio_chip cs3_gpio;
>
> long simpad_get_cs3_ro(void)
> @@ -379,8 +379,6 @@ static int __init simpad_init(void)
> {
> int ret;
>
> - spin_lock_init(&cs3_lock);
> -
> cs3_gpio.label = "simpad_cs3";
> cs3_gpio.base = SIMPAD_CS3_GPIO_BASE;
> cs3_gpio.ngpio = 24;
>
> .
>

2021-04-01 07:53:51

by Dan Carpenter

Subject: Re: [PATCH -next] i2c: gpio: use DEFINE_SPINLOCK() for spinlock

On Thu, Apr 01, 2021 at 11:38:30AM +0800, chenlifu wrote:
> Kindly pinging ...
>
> Best Regards,
> Chen Lifu
>
> 在 2021/3/27 17:52, Chen Lifu 写道:

It's to early to start asking for a response. Please wait at least two
weeks. (Probably four weeks if the merge window was open).

regards,
dan carpenter