2021-04-01 07:51:21

by zhengzucheng

Subject: [PATCH -next] serial: 8250: Make symbol 'brcmuart_debugfs_root' static

symbol 'brcmuart_debugfs_root' is not used outside of 8250_bcm7271.c,
so this commit marks it static.

Signed-off-by: Zucheng Zheng <[email protected]>
---
drivers/tty/serial/8250/8250_bcm7271.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_bcm7271.c b/drivers/tty/serial/8250/8250_bcm7271.c
index 63883185fccd..ebba7f2e960c 100644
--- a/drivers/tty/serial/8250/8250_bcm7271.c
+++ b/drivers/tty/serial/8250/8250_bcm7271.c
@@ -239,7 +239,7 @@ struct brcmuart_priv {
u32 rx_abort;
};

-struct dentry *brcmuart_debugfs_root;
+static struct dentry *brcmuart_debugfs_root;

/*
* Register access routines
--
2.17.1

2021-04-06 15:23:39

by Jiri Slaby

Subject: Re: [PATCH -next] serial: 8250: Make symbol 'brcmuart_debugfs_root' static

On 01. 04. 21, 9:49, Zucheng Zheng wrote:
> symbol 'brcmuart_debugfs_root' is not used outside of 8250_bcm7271.c,
> so this commit marks it static.
>
> Signed-off-by: Zucheng Zheng <[email protected]>

Reviewed-by: Jiri Slaby <[email protected]>

> ---
> drivers/tty/serial/8250/8250_bcm7271.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_bcm7271.c b/drivers/tty/serial/8250/8250_bcm7271.c
> index 63883185fccd..ebba7f2e960c 100644
> --- a/drivers/tty/serial/8250/8250_bcm7271.c
> +++ b/drivers/tty/serial/8250/8250_bcm7271.c
> @@ -239,7 +239,7 @@ struct brcmuart_priv {
> u32 rx_abort;
> };
>
> -struct dentry *brcmuart_debugfs_root;
> +static struct dentry *brcmuart_debugfs_root;
>
> /*
> * Register access routines
>


--
js