2021-04-08 11:36:33

by Wang Wensheng

Subject: [PATCH -next] IB/hfi1: Fix error return code in parse_platform_config()

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 7724105686e7 ("IB/hfi1: add driver files")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Wang Wensheng <[email protected]>
---
drivers/infiniband/hw/hfi1/firmware.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/hw/hfi1/firmware.c b/drivers/infiniband/hw/hfi1/firmware.c
index 0e83d4b..2cf102b 100644
--- a/drivers/infiniband/hw/hfi1/firmware.c
+++ b/drivers/infiniband/hw/hfi1/firmware.c
@@ -1916,6 +1916,7 @@ int parse_platform_config(struct hfi1_devdata *dd)
dd_dev_err(dd, "%s: Failed CRC check at offset %ld\n",
__func__, (ptr -
(u32 *)dd->platform_config.data));
+ ret = -EINVAL;
goto bail;
}
/* Jump the CRC DWORD */
--
2.9.4

2021-04-13 06:30:15

by Jason Gunthorpe

Subject: Re: [PATCH -next] IB/hfi1: Fix error return code in parse_platform_config()

On Thu, Apr 08, 2021 at 11:31:40AM +0000, Wang Wensheng wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 7724105686e7 ("IB/hfi1: add driver files")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Wang Wensheng <[email protected]>
> ---
> drivers/infiniband/hw/hfi1/firmware.c | 1 +
> 1 file changed, 1 insertion(+)

Applied to for-next, thanks

Jason