2021-04-09 02:48:17

by Jiabing Wan

Subject: [PATCH] fs: cifs: Remove repeated struct declaration

struct cifs_writedata is declared twice.
One is declared at 209th line.
And struct cifs_writedata is defined blew.
The declaration hear is not needed. Remove the duplicate.

Signed-off-by: Wan Jiabing <[email protected]>
---
fs/cifs/cifsglob.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
index ec824ab8c5ca..5ec60745034e 100644
--- a/fs/cifs/cifsglob.h
+++ b/fs/cifs/cifsglob.h
@@ -1316,8 +1316,6 @@ struct cifs_readdata {
struct page **pages;
};

-struct cifs_writedata;
-
/* asynchronous write support */
struct cifs_writedata {
struct kref refcount;
--
2.25.1

2021-04-09 03:54:04

by Steve French

Subject: Re: [PATCH] fs: cifs: Remove repeated struct declaration

merged into cifs-2.6.git for-next

On Thu, Apr 8, 2021 at 9:47 PM Wan Jiabing <[email protected]> wrote:
>
> struct cifs_writedata is declared twice.
> One is declared at 209th line.
> And struct cifs_writedata is defined blew.
> The declaration hear is not needed. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> fs/cifs/cifsglob.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
> index ec824ab8c5ca..5ec60745034e 100644
> --- a/fs/cifs/cifsglob.h
> +++ b/fs/cifs/cifsglob.h
> @@ -1316,8 +1316,6 @@ struct cifs_readdata {
> struct page **pages;
> };
>
> -struct cifs_writedata;
> -
> /* asynchronous write support */
> struct cifs_writedata {
> struct kref refcount;
> --
> 2.25.1
>


--
Thanks,

Steve