2021-04-12 13:49:57

by Neil Armstrong

Subject: [PATCH] media: meson-ge2d: fix rotation parameters

With these settings, 90deg and 270deg rotation leads to inverted
vertical, fix them to have correct rotation.

Fixes: 59a635327ca7 ("media: meson: Add M2M driver for the Amlogic GE2D Accelerator Unit")
Signed-off-by: Neil Armstrong <[email protected]>
---
drivers/media/platform/meson/ge2d/ge2d.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/meson/ge2d/ge2d.c b/drivers/media/platform/meson/ge2d/ge2d.c
index 153612ca96fc..a1393fefa8ae 100644
--- a/drivers/media/platform/meson/ge2d/ge2d.c
+++ b/drivers/media/platform/meson/ge2d/ge2d.c
@@ -757,7 +757,7 @@ static int ge2d_s_ctrl(struct v4l2_ctrl *ctrl)

if (ctrl->val == 90) {
ctx->hflip = 0;
- ctx->vflip = 0;
+ ctx->vflip = 1;
ctx->xy_swap = 1;
} else if (ctrl->val == 180) {
ctx->hflip = 1;
@@ -765,7 +765,7 @@ static int ge2d_s_ctrl(struct v4l2_ctrl *ctrl)
ctx->xy_swap = 0;
} else if (ctrl->val == 270) {
ctx->hflip = 1;
- ctx->vflip = 1;
+ ctx->vflip = 0;
ctx->xy_swap = 1;
} else {
ctx->hflip = 0;
--
2.25.1

2021-04-19 22:14:33

by Kevin Hilman

Subject: Re: [PATCH] media: meson-ge2d: fix rotation parameters

Neil Armstrong <[email protected]> writes:

> With these settings, 90deg and 270deg rotation leads to inverted
> vertical, fix them to have correct rotation.
>
> Fixes: 59a635327ca7 ("media: meson: Add M2M driver for the Amlogic GE2D Accelerator Unit")
> Signed-off-by: Neil Armstrong <[email protected]>

Reviewed-by: Kevin Hilman <[email protected]>

> ---
> drivers/media/platform/meson/ge2d/ge2d.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/meson/ge2d/ge2d.c b/drivers/media/platform/meson/ge2d/ge2d.c
> index 153612ca96fc..a1393fefa8ae 100644
> --- a/drivers/media/platform/meson/ge2d/ge2d.c
> +++ b/drivers/media/platform/meson/ge2d/ge2d.c
> @@ -757,7 +757,7 @@ static int ge2d_s_ctrl(struct v4l2_ctrl *ctrl)
>
> if (ctrl->val == 90) {
> ctx->hflip = 0;
> - ctx->vflip = 0;
> + ctx->vflip = 1;
> ctx->xy_swap = 1;
> } else if (ctrl->val == 180) {
> ctx->hflip = 1;
> @@ -765,7 +765,7 @@ static int ge2d_s_ctrl(struct v4l2_ctrl *ctrl)
> ctx->xy_swap = 0;
> } else if (ctrl->val == 270) {
> ctx->hflip = 1;
> - ctx->vflip = 1;
> + ctx->vflip = 0;
> ctx->xy_swap = 1;
> } else {
> ctx->hflip = 0;
> --
> 2.25.1