2021-04-12 16:51:50

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v2] staging: rtl8723bs: remove unnecessary adapter

On Mon, Apr 12, 2021 at 04:43:56PM +0000, Bryan Brattlof wrote:
> The if2 adapter is defined in rtw_dvr_init() and in the dvobj_priv
> structure but never used anywhere in the driver. This will remove all
> definitions of if2
>
> Signed-off-by: Bryan Brattlof <[email protected]>
> ---
> drivers/staging/rtl8723bs/include/drv_types.h | 1 -
> drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 10 ++++------
> 2 files changed, 4 insertions(+), 7 deletions(-)

What changed from v1? That goes below the --- line.

v3?


2021-04-12 17:12:17

by Bryan Brattlof

[permalink] [raw]
Subject: Re: [PATCH v2] staging: rtl8723bs: remove unnecessary adapter

On Mon, Apr 12, 2021 at 06:45:35PM +0200, Greg Kroah-Hartman wrote:
>
>On Mon, Apr 12, 2021 at 04:43:56PM +0000, Bryan Brattlof wrote:
>> The if2 adapter is defined in rtw_dvr_init() and in the dvobj_priv
>> structure but never used anywhere in the driver. This will remove all
>> definitions of if2
>>
>> Signed-off-by: Bryan Brattlof <[email protected]>
>> ---
>> drivers/staging/rtl8723bs/include/drv_types.h | 1 -
>> drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 10 ++++------
>> 2 files changed, 4 insertions(+), 7 deletions(-)
>
>What changed from v1? That goes below the --- line.
>
>v3?

Oops.

it's the simple things that always seem to be the hardest :)

During the rebase to next-20210412, I lost the bracket on the
conditional statement:

394: +free_if1:
395: if (status != _SUCCESS && if1) {
^

I'll be sending v3 shortly with a proper change long :)
--
~Bryan