2021-04-14 15:56:24

by Aline Santana Cordeiro

Subject: [PATCH] staging: media: tegra-video: Align line break to match with the open parenthesis in file vi.c

Align line break to match with the open parenthesis.
Issue detected by checkpatch.pl.

Signed-off-by: Aline Santana Cordeiro <[email protected]>
---
drivers/staging/media/tegra-video/vi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media/tegra-video/vi.c
index 7a09061c..9878d1e 100644
--- a/drivers/staging/media/tegra-video/vi.c
+++ b/drivers/staging/media/tegra-video/vi.c
@@ -1813,7 +1813,8 @@ static int tegra_vi_graph_parse_one(struct tegra_vi_channel *chan,
}

tvge = v4l2_async_notifier_add_fwnode_subdev(&chan->notifier,
- remote, struct tegra_vi_graph_entity);
+ remote,
+ struct tegra_vi_graph_entity);
if (IS_ERR(tvge)) {
ret = PTR_ERR(tvge);
dev_err(vi->dev,
--
2.7.4

2021-04-15 14:08:33

by Hans Verkuil

Subject: Re: [PATCH] staging: media: tegra-video: Align line break to match with the open parenthesis in file vi.c

On 14/04/2021 15:09, Aline Santana Cordeiro wrote:
> Align line break to match with the open parenthesis.
> Issue detected by checkpatch.pl.
>
> Signed-off-by: Aline Santana Cordeiro <[email protected]>
> ---
> drivers/staging/media/tegra-video/vi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media/tegra-video/vi.c
> index 7a09061c..9878d1e 100644
> --- a/drivers/staging/media/tegra-video/vi.c
> +++ b/drivers/staging/media/tegra-video/vi.c
> @@ -1813,7 +1813,8 @@ static int tegra_vi_graph_parse_one(struct tegra_vi_channel *chan,
> }
>
> tvge = v4l2_async_notifier_add_fwnode_subdev(&chan->notifier,
> - remote, struct tegra_vi_graph_entity);
> + remote,

Add this line to the previous line. That looks a bit better and is one line
shorter.

Regards,

Hans

> + struct tegra_vi_graph_entity);
> if (IS_ERR(tvge)) {
> ret = PTR_ERR(tvge);
> dev_err(vi->dev,
>