The following series of patches add support for CAN transceivers.
TCAN1042 has a standby signal that needs to be pulled high for
sending/receiving messages[1]. TCAN1043 has a enable signal along with
standby signal that needs to be pulled up for sending/receiving
messages[2], and other combinations of the two lines can be used to put the
transceiver in different states to reduce power consumption. On boards
like the AM654-idk and J721e-evm these signals are controlled using gpios.
Patch 1 rewords the comment that restricts max_link_rate attribute to have
units of Mbps.
Patch 2 adds an API for devm_of_phy_optional_get_by_index
Patch 3 models the transceiver as a phy device tree node with properties
for max bit rate supported, gpio properties for indicating gpio pin numbers
to which standby and enable signals are connected.
Patch 4 adds a generic driver to support CAN transceivers.
Patches 5 & 6 add support for implementing the transceiver as a phy of
m_can_platform driver.
changes since v1:
- Added patch 1 (in v2) that rewords the comment that restrict
max_link_rate attribute to have units of Mbps.
- Added patch 2 (in v2) that adds an API for
devm_of_phy_optional_get_by_index
- Patch 1 (in v1)
- updated MAINTAINERS file
- Patch 2 (in v1)
- replaced m_can with CAN to make the driver independent of CAN driver
- Added prefix CAN_TRANSCEIVER for EN_PRESENT and STB_PRESENT
- Added new line before return statements in power_on() and power_off
- Added error handling patch for devm_kzalloc()
- used the max_link_rate attribute directly instead of dividing it by
1000000
- removed the spaces before GPIOD_OUT_LOW in devm_gpiod_get()
- Corrected requested value for standby-gpios to GPIOD_OUT_HIGH
- Updated MAINTAINERS file
- Patch 3 (in v1)
- replaced minItems with maxItems
- Removed phy-names property as there is only one phy
- Patch 4 (in v1)
- replaced dev_warn with dev_info when no transceiver is found
- Added struct phy * field in m_can_classdev struct
- moved phy_power_on and phy_power_off to m_can_open and m_can_close
respectively
- Moved the check for max_bit_rate to generice transceiver driver
[1] - https://www.ti.com/lit/ds/symlink/tcan1042h.pdf
[2] - https://www.ti.com/lit/ds/symlink/tcan1043-q1.pdf
Aswath Govindraju (4):
phy: core: Reword the comment specifying the units of max_link_rate to
be Mbps
phy: Add API for devm_of_phy_optional_get_by_index
dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers
phy: phy-can-transceiver: Add support for generic CAN transceiver
driver
Faiz Abbas (2):
dt-bindings: net: can: Document transceiver implementation as phy
can: m_can: Add support for transceiver as phy
.../bindings/net/can/bosch,m_can.yaml | 3 +
.../bindings/phy/ti,tcan104x-can.yaml | 56 +++++++
MAINTAINERS | 2 +
drivers/net/can/m_can/m_can.c | 18 +++
drivers/net/can/m_can/m_can.h | 2 +
drivers/net/can/m_can/m_can_platform.c | 15 ++
drivers/phy/Kconfig | 9 ++
drivers/phy/Makefile | 1 +
drivers/phy/phy-can-transceiver.c | 146 ++++++++++++++++++
drivers/phy/phy-core.c | 26 ++++
include/linux/phy/phy.h | 4 +-
11 files changed, 281 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
create mode 100644 drivers/phy/phy-can-transceiver.c
--
2.17.1
In some subsystems (eg. CAN, SPI), the max link rate supported can be less
than 1 Mbps and if the unit for max_link_rate is Mbps then it can't be
used. Therefore, leave the decision of units to be used, to the producer
and consumer.
Signed-off-by: Aswath Govindraju <[email protected]>
---
include/linux/phy/phy.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
index 0ed434d02196..f3286f4cd306 100644
--- a/include/linux/phy/phy.h
+++ b/include/linux/phy/phy.h
@@ -125,7 +125,7 @@ struct phy_ops {
/**
* struct phy_attrs - represents phy attributes
* @bus_width: Data path width implemented by PHY
- * @max_link_rate: Maximum link rate supported by PHY (in Mbps)
+ * @max_link_rate: Maximum link rate supported by PHY (units to be decided by producer and consumer)
* @mode: PHY mode
*/
struct phy_attrs {
--
2.17.1
Add binding documentation for TI TCAN104x CAN transceivers.
Signed-off-by: Aswath Govindraju <[email protected]>
---
.../bindings/phy/ti,tcan104x-can.yaml | 56 +++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 57 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
new file mode 100644
index 000000000000..4abfc30a97d0
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
@@ -0,0 +1,56 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/phy/ti,tcan104x-can.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: TCAN104x CAN TRANSCEIVER PHY
+
+maintainers:
+ - Aswath Govindraju <[email protected]>
+
+properties:
+ $nodename:
+ pattern: "^tcan104x-phy"
+
+ compatible:
+ enum:
+ - ti,tcan1042
+ - ti,tcan1043
+
+ '#phy-cells':
+ const: 0
+
+ standby-gpios:
+ description:
+ gpio node to toggle standby signal on transceiver
+ maxItems: 1
+
+ enable-gpios:
+ description:
+ gpio node to toggle enable signal on transceiver
+ maxItems: 1
+
+ max-bitrate:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ max bit rate supported in bps
+ minimum: 1
+
+required:
+ - compatible
+ - '#phy-cells'
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ transceiver1: tcan104x-phy {
+ compatible = "ti,tcan1043";
+ #phy-cells = <0>;
+ max-bitrate = <5000000>;
+ standby-gpios = <&wakeup_gpio1 16 GPIO_ACTIVE_LOW>;
+ enable-gpios = <&main_gpio1 67 GPIO_ACTIVE_LOW>;
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index 84ef96a444c3..e666d33af10d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4046,6 +4046,7 @@ W: https://github.com/linux-can
T: git git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git
T: git git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git
F: Documentation/devicetree/bindings/net/can/
+F: Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
F: drivers/net/can/
F: include/linux/can/bittiming.h
F: include/linux/can/dev.h
--
2.17.1
On 14.04.2021 19:35:15, Aswath Govindraju wrote:
> The following series of patches add support for CAN transceivers.
>
> TCAN1042 has a standby signal that needs to be pulled high for
> sending/receiving messages[1]. TCAN1043 has a enable signal along with
> standby signal that needs to be pulled up for sending/receiving
> messages[2], and other combinations of the two lines can be used to put the
> transceiver in different states to reduce power consumption. On boards
> like the AM654-idk and J721e-evm these signals are controlled using gpios.
>
> Patch 1 rewords the comment that restricts max_link_rate attribute to have
> units of Mbps.
>
> Patch 2 adds an API for devm_of_phy_optional_get_by_index
You probably want to split this into 2 or even 3 separate series. The
first one would be patches 1+2 then 3+4 they can go via the phy tree.
Patches 5+6 can go via linux-can-next
> Patch 3 models the transceiver as a phy device tree node with properties
> for max bit rate supported, gpio properties for indicating gpio pin numbers
> to which standby and enable signals are connected.
>
> Patch 4 adds a generic driver to support CAN transceivers.
>
> Patches 5 & 6 add support for implementing the transceiver as a phy of
> m_can_platform driver.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
From: Faiz Abbas <[email protected]>
Some transceivers need a configuration step (for example, pulling the
standby or enable lines) for them to start sending messages. The
transceiver can be implemented as a phy with the configuration done in the
phy driver. The bit rate limitation can the be obtained by the driver using
the phy node.
Document the above implementation in the bosch mcan bindings
Signed-off-by: Faiz Abbas <[email protected]>
Signed-off-by: Aswath Govindraju <[email protected]>
---
Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
index 798fa5fb7bb2..25f74db46bae 100644
--- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
+++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
@@ -109,6 +109,9 @@ properties:
can-transceiver:
$ref: can-transceiver.yaml#
+ phys:
+ maxItems: 1
+
required:
- compatible
- reg
--
2.17.1
The driver adds support for generic CAN transceivers. Currently
the modes supported by this driver are standby and normal modes for TI
TCAN1042 and TCAN1043 CAN transceivers.
The transceiver is modelled as a phy with pins controlled by gpios, to put
the transceiver in various device functional modes. It also gets the phy
attribute max_link_rate for the usage of CAN drivers.
Signed-off-by: Aswath Govindraju <[email protected]>
---
MAINTAINERS | 1 +
drivers/phy/Kconfig | 9 ++
drivers/phy/Makefile | 1 +
drivers/phy/phy-can-transceiver.c | 146 ++++++++++++++++++++++++++++++
4 files changed, 157 insertions(+)
create mode 100644 drivers/phy/phy-can-transceiver.c
diff --git a/MAINTAINERS b/MAINTAINERS
index e666d33af10d..70e1438c372d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4047,6 +4047,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git
T: git git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git
F: Documentation/devicetree/bindings/net/can/
F: Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
+F: drivers/phy/phy-can-transceiver.c
F: drivers/net/can/
F: include/linux/can/bittiming.h
F: include/linux/can/dev.h
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 54c1f2f0985f..51902b629fc6 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -61,6 +61,15 @@ config USB_LGM_PHY
interface to interact with USB GEN-II and USB 3.x PHY that is part
of the Intel network SOC.
+config PHY_CAN_TRANSCEIVER
+ tristate "CAN transceiver PHY"
+ select GENERIC_PHY
+ help
+ This option enables support for CAN transceivers as a PHY. This
+ driver provides function for putting the transceivers in various
+ functional modes using gpios and sets the attribute max link
+ rate, for mcan drivers.
+
source "drivers/phy/allwinner/Kconfig"
source "drivers/phy/amlogic/Kconfig"
source "drivers/phy/broadcom/Kconfig"
diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile
index adac1b1a39d1..9c66101c9605 100644
--- a/drivers/phy/Makefile
+++ b/drivers/phy/Makefile
@@ -9,6 +9,7 @@ obj-$(CONFIG_PHY_LPC18XX_USB_OTG) += phy-lpc18xx-usb-otg.o
obj-$(CONFIG_PHY_XGENE) += phy-xgene.o
obj-$(CONFIG_PHY_PISTACHIO_USB) += phy-pistachio-usb.o
obj-$(CONFIG_USB_LGM_PHY) += phy-lgm-usb.o
+obj-$(CONFIG_PHY_CAN_TRANSCEIVER) += phy-can-transceiver.o
obj-y += allwinner/ \
amlogic/ \
broadcom/ \
diff --git a/drivers/phy/phy-can-transceiver.c b/drivers/phy/phy-can-transceiver.c
new file mode 100644
index 000000000000..f2976c1f4d0f
--- /dev/null
+++ b/drivers/phy/phy-can-transceiver.c
@@ -0,0 +1,146 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * phy-can-transceiver.c - phy driver for CAN transceivers
+ *
+ * Copyright (C) 2021 Texas Instruments Incorporated - http://www.ti.com
+ *
+ */
+#include<linux/phy/phy.h>
+#include<linux/platform_device.h>
+#include<linux/module.h>
+#include<linux/gpio.h>
+#include<linux/gpio/consumer.h>
+
+struct can_transceiver_data {
+ u32 flags;
+#define CAN_TRANSCEIVER_STB_PRESENT BIT(0)
+#define CAN_TRANSCEIVER_EN_PRESENT BIT(1)
+};
+
+struct can_transceiver_phy {
+ struct phy *generic_phy;
+ struct gpio_desc *standby_gpio;
+ struct gpio_desc *enable_gpio;
+};
+
+/* Power on function */
+static int can_transceiver_phy_power_on(struct phy *phy)
+{
+ struct can_transceiver_phy *can_transceiver_phy = phy_get_drvdata(phy);
+
+ if (can_transceiver_phy->standby_gpio)
+ gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 0);
+ if (can_transceiver_phy->enable_gpio)
+ gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 1);
+
+ return 0;
+}
+
+/* Power off function */
+static int can_transceiver_phy_power_off(struct phy *phy)
+{
+ struct can_transceiver_phy *can_transceiver_phy = phy_get_drvdata(phy);
+
+ if (can_transceiver_phy->standby_gpio)
+ gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 1);
+ if (can_transceiver_phy->enable_gpio)
+ gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 0);
+
+ return 0;
+}
+
+static const struct phy_ops can_transceiver_phy_ops = {
+ .power_on = can_transceiver_phy_power_on,
+ .power_off = can_transceiver_phy_power_off,
+ .owner = THIS_MODULE,
+};
+
+static const struct can_transceiver_data tcan1042_drvdata = {
+ .flags = CAN_TRANSCEIVER_STB_PRESENT,
+};
+
+static const struct can_transceiver_data tcan1043_drvdata = {
+ .flags = CAN_TRANSCEIVER_STB_PRESENT | CAN_TRANSCEIVER_EN_PRESENT,
+};
+
+static const struct of_device_id can_transceiver_phy_ids[] = {
+ {
+ .compatible = "ti,tcan1042",
+ .data = &tcan1042_drvdata
+ },
+ {
+ .compatible = "ti,tcan1043",
+ .data = &tcan1043_drvdata
+ },
+ { }
+};
+MODULE_DEVICE_TABLE(of, can_transceiver_phy_ids);
+
+int can_transceiver_phy_probe(struct platform_device *pdev)
+{
+ struct phy_provider *phy_provider;
+ struct device *dev = &pdev->dev;
+ struct can_transceiver_phy *can_transceiver_phy;
+ const struct can_transceiver_data *drvdata;
+ const struct of_device_id *match;
+ struct phy *phy;
+ struct gpio_desc *standby_gpio;
+ struct gpio_desc *enable_gpio;
+ u32 max_bitrate = 0;
+
+ can_transceiver_phy = devm_kzalloc(dev, sizeof(struct can_transceiver_phy), GFP_KERNEL);
+ if (!can_transceiver_phy)
+ return -ENOMEM;
+
+ match = of_match_node(can_transceiver_phy_ids, pdev->dev.of_node);
+ drvdata = match->data;
+
+ phy = devm_phy_create(dev, dev->of_node,
+ &can_transceiver_phy_ops);
+ if (IS_ERR(phy)) {
+ dev_err(dev, "failed to create can transceiver phy\n");
+ return PTR_ERR(phy);
+ }
+
+ device_property_read_u32(dev, "max-bitrate", &max_bitrate);
+ if (!max_bitrate)
+ dev_warn(dev, "Invalid value for transceiver max bitrate. Ignoring bitrate limit\n");
+ phy->attrs.max_link_rate = max_bitrate;
+
+ can_transceiver_phy->generic_phy = phy;
+
+ if (drvdata->flags & CAN_TRANSCEIVER_STB_PRESENT) {
+ standby_gpio = devm_gpiod_get(dev, "standby", GPIOD_OUT_HIGH);
+ if (IS_ERR(standby_gpio))
+ return PTR_ERR(standby_gpio);
+ can_transceiver_phy->standby_gpio = standby_gpio;
+ }
+
+ if (drvdata->flags & CAN_TRANSCEIVER_EN_PRESENT) {
+ enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW);
+ if (IS_ERR(enable_gpio))
+ return PTR_ERR(enable_gpio);
+ can_transceiver_phy->enable_gpio = enable_gpio;
+ }
+
+ phy_set_drvdata(can_transceiver_phy->generic_phy, can_transceiver_phy);
+
+ phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
+
+ return PTR_ERR_OR_ZERO(phy_provider);
+}
+
+static struct platform_driver can_transceiver_phy_driver = {
+ .probe = can_transceiver_phy_probe,
+ .driver = {
+ .name = "can-transceiver-phy",
+ .of_match_table = can_transceiver_phy_ids,
+ },
+};
+
+module_platform_driver(can_transceiver_phy_driver);
+
+MODULE_AUTHOR("Faiz Abbas <[email protected]>");
+MODULE_AUTHOR("Aswath Govindraju <[email protected]>");
+MODULE_DESCRIPTION("CAN TRANSCEIVER PHY driver");
+MODULE_LICENSE("GPL v2");
--
2.17.1
From: Faiz Abbas <[email protected]>
Add support for implementing transceiver node as phy. The max_bitrate is
obtained by getting a phy attribute.
Signed-off-by: Faiz Abbas <[email protected]>
Signed-off-by: Aswath Govindraju <[email protected]>
---
drivers/net/can/m_can/m_can.c | 18 ++++++++++++++++++
drivers/net/can/m_can/m_can.h | 2 ++
drivers/net/can/m_can/m_can_platform.c | 15 +++++++++++++++
3 files changed, 35 insertions(+)
diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
index 34073cd077e4..4807a1f69cc7 100644
--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -21,6 +21,7 @@
#include <linux/iopoll.h>
#include <linux/can/dev.h>
#include <linux/pinctrl/consumer.h>
+#include <linux/phy/phy.h>
#include "m_can.h"
@@ -1514,6 +1515,7 @@ static void m_can_stop(struct net_device *dev)
static int m_can_close(struct net_device *dev)
{
struct m_can_classdev *cdev = netdev_priv(dev);
+ int err;
netif_stop_queue(dev);
@@ -1536,6 +1538,14 @@ static int m_can_close(struct net_device *dev)
close_candev(dev);
can_led_event(dev, CAN_LED_EVENT_STOP);
+ if (cdev->transceiver) {
+ err = phy_power_off(cdev->transceiver);
+ if (err) {
+ netdev_err(dev, "error powering off phy, err=%d\n", err);
+ return err;
+ }
+ }
+
return 0;
}
@@ -1720,6 +1730,14 @@ static int m_can_open(struct net_device *dev)
struct m_can_classdev *cdev = netdev_priv(dev);
int err;
+ if (cdev->transceiver) {
+ err = phy_power_on(cdev->transceiver);
+ if (err) {
+ netdev_err(dev, "error powering on phy, err=%d\n", err);
+ return err;
+ }
+ }
+
err = m_can_clk_start(cdev);
if (err)
return err;
diff --git a/drivers/net/can/m_can/m_can.h b/drivers/net/can/m_can/m_can.h
index ace071c3e58c..38cad068abad 100644
--- a/drivers/net/can/m_can/m_can.h
+++ b/drivers/net/can/m_can/m_can.h
@@ -28,6 +28,7 @@
#include <linux/iopoll.h>
#include <linux/can/dev.h>
#include <linux/pinctrl/consumer.h>
+#include <linux/phy/phy.h>
/* m_can lec values */
enum m_can_lec_type {
@@ -82,6 +83,7 @@ struct m_can_classdev {
struct workqueue_struct *tx_wq;
struct work_struct tx_work;
struct sk_buff *tx_skb;
+ struct phy *transceiver;
struct can_bittiming_const *bit_timing;
struct can_bittiming_const *data_timing;
diff --git a/drivers/net/can/m_can/m_can_platform.c b/drivers/net/can/m_can/m_can_platform.c
index 599de0e08cd7..566ba25fb186 100644
--- a/drivers/net/can/m_can/m_can_platform.c
+++ b/drivers/net/can/m_can/m_can_platform.c
@@ -6,6 +6,7 @@
// Copyright (C) 2018-19 Texas Instruments Incorporated - http://www.ti.com/
#include <linux/platform_device.h>
+#include <linux/phy/phy.h>
#include "m_can.h"
@@ -67,6 +68,7 @@ static int m_can_plat_probe(struct platform_device *pdev)
struct resource *res;
void __iomem *addr;
void __iomem *mram_addr;
+ struct phy *transceiver;
int irq, ret = 0;
mcan_class = m_can_class_allocate_dev(&pdev->dev,
@@ -101,6 +103,18 @@ static int m_can_plat_probe(struct platform_device *pdev)
goto probe_fail;
}
+ transceiver = devm_of_phy_optional_get_by_index(&pdev->dev, pdev->dev.of_node, 0);
+ if (IS_ERR(transceiver)) {
+ ret = PTR_ERR(transceiver);
+ dev_err(&pdev->dev, "error while getting phy, err=%d\n", ret);
+ return ret;
+ }
+
+ if (!transceiver)
+ dev_info(&pdev->dev, "No transceiver phy found\n");
+ else
+ priv->cdev.can.bitrate_max = transceiver->attrs.max_link_rate;
+
priv->base = addr;
priv->mram_base = mram_addr;
@@ -108,6 +122,7 @@ static int m_can_plat_probe(struct platform_device *pdev)
mcan_class->pm_clock_support = 1;
mcan_class->can.clock.freq = clk_get_rate(mcan_class->cclk);
mcan_class->dev = &pdev->dev;
+ mcan_class->transceiver = transceiver;
mcan_class->ops = &m_can_plat_ops;
--
2.17.1
On 14.04.2021 19:35:19, Aswath Govindraju wrote:
> The driver adds support for generic CAN transceivers. Currently
> the modes supported by this driver are standby and normal modes for TI
> TCAN1042 and TCAN1043 CAN transceivers.
>
> The transceiver is modelled as a phy with pins controlled by gpios, to put
> the transceiver in various device functional modes. It also gets the phy
> attribute max_link_rate for the usage of CAN drivers.
>
> Signed-off-by: Aswath Govindraju <[email protected]>
> ---
> MAINTAINERS | 1 +
> drivers/phy/Kconfig | 9 ++
> drivers/phy/Makefile | 1 +
> drivers/phy/phy-can-transceiver.c | 146 ++++++++++++++++++++++++++++++
> 4 files changed, 157 insertions(+)
> create mode 100644 drivers/phy/phy-can-transceiver.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e666d33af10d..70e1438c372d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4047,6 +4047,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git
> F: Documentation/devicetree/bindings/net/can/
> F: Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> +F: drivers/phy/phy-can-transceiver.c
> F: drivers/net/can/
please keep this alphabetically sorted
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
On 14.04.2021 19:35:18, Aswath Govindraju wrote:
> Add binding documentation for TI TCAN104x CAN transceivers.
>
> Signed-off-by: Aswath Govindraju <[email protected]>
> ---
> .../bindings/phy/ti,tcan104x-can.yaml | 56 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 57 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
>
> diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> new file mode 100644
> index 000000000000..4abfc30a97d0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/phy/ti,tcan104x-can.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: TCAN104x CAN TRANSCEIVER PHY
> +
> +maintainers:
> + - Aswath Govindraju <[email protected]>
> +
> +properties:
> + $nodename:
> + pattern: "^tcan104x-phy"
> +
> + compatible:
> + enum:
> + - ti,tcan1042
> + - ti,tcan1043
Can you ensure that the 1042 has only the standby gpio and the 1043 has both?
> +
> + '#phy-cells':
> + const: 0
> +
> + standby-gpios:
> + description:
> + gpio node to toggle standby signal on transceiver
> + maxItems: 1
> +
> + enable-gpios:
> + description:
> + gpio node to toggle enable signal on transceiver
> + maxItems: 1
> +
> + max-bitrate:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + max bit rate supported in bps
> + minimum: 1
> +
> +required:
> + - compatible
> + - '#phy-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + transceiver1: tcan104x-phy {
> + compatible = "ti,tcan1043";
> + #phy-cells = <0>;
> + max-bitrate = <5000000>;
> + standby-gpios = <&wakeup_gpio1 16 GPIO_ACTIVE_LOW>;
> + enable-gpios = <&main_gpio1 67 GPIO_ACTIVE_LOW>;
AFAICS the enable gpio is active high.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Hi Marc,
On 14/04/21 9:03 pm, Marc Kleine-Budde wrote:
> On 14.04.2021 19:35:18, Aswath Govindraju wrote:
>> Add binding documentation for TI TCAN104x CAN transceivers.
>>
>> Signed-off-by: Aswath Govindraju <[email protected]>
>> ---
>> .../bindings/phy/ti,tcan104x-can.yaml | 56 +++++++++++++++++++
>> MAINTAINERS | 1 +
>> 2 files changed, 57 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
>> new file mode 100644
>> index 000000000000..4abfc30a97d0
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
>> @@ -0,0 +1,56 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/phy/ti,tcan104x-can.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>> +
>> +title: TCAN104x CAN TRANSCEIVER PHY
>> +
>> +maintainers:
>> + - Aswath Govindraju <[email protected]>
>> +
>> +properties:
>> + $nodename:
>> + pattern: "^tcan104x-phy"
>> +
>> + compatible:
>> + enum:
>> + - ti,tcan1042
>> + - ti,tcan1043
>
> Can you ensure that the 1042 has only the standby gpio and the 1043 has both?
>
In the driver, it is the way the flags have been set for ti,tcan1042 and
ti,tcan1043.
>> +
>> + '#phy-cells':
>> + const: 0
>> +
>> + standby-gpios:
>> + description:
>> + gpio node to toggle standby signal on transceiver
>> + maxItems: 1
>> +
>> + enable-gpios:
>> + description:
>> + gpio node to toggle enable signal on transceiver
>> + maxItems: 1
>> +
>> + max-bitrate:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description:
>> + max bit rate supported in bps
>> + minimum: 1
>> +
>> +required:
>> + - compatible
>> + - '#phy-cells'
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/gpio/gpio.h>
>> +
>> + transceiver1: tcan104x-phy {
>> + compatible = "ti,tcan1043";
>> + #phy-cells = <0>;
>> + max-bitrate = <5000000>;
>> + standby-gpios = <&wakeup_gpio1 16 GPIO_ACTIVE_LOW>;
>> + enable-gpios = <&main_gpio1 67 GPIO_ACTIVE_LOW>;
>
> AFAICS the enable gpio is active high.
>
I will correct this in the respin.
Thanks,
Aswath
> Marc
>
On 15.04.2021 11:57:20, Aswath Govindraju wrote:
> Hi Marc,
>
> On 14/04/21 9:03 pm, Marc Kleine-Budde wrote:
> > On 14.04.2021 19:35:18, Aswath Govindraju wrote:
> >> Add binding documentation for TI TCAN104x CAN transceivers.
> >>
> >> Signed-off-by: Aswath Govindraju <[email protected]>
> >> ---
> >> .../bindings/phy/ti,tcan104x-can.yaml | 56 +++++++++++++++++++
> >> MAINTAINERS | 1 +
> >> 2 files changed, 57 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> >> new file mode 100644
> >> index 000000000000..4abfc30a97d0
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> >> @@ -0,0 +1,56 @@
> >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >> +%YAML 1.2
> >> +---
> >> +$id: "http://devicetree.org/schemas/phy/ti,tcan104x-can.yaml#"
> >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> >> +
> >> +title: TCAN104x CAN TRANSCEIVER PHY
> >> +
> >> +maintainers:
> >> + - Aswath Govindraju <[email protected]>
Can you create a maintainers entry for this file with your address?
> >> +
> >> +properties:
> >> + $nodename:
> >> + pattern: "^tcan104x-phy"
> >> +
> >> + compatible:
> >> + enum:
> >> + - ti,tcan1042
> >> + - ti,tcan1043
> >
> > Can you ensure that the 1042 has only the standby gpio and the 1043 has both?
> >
>
> In the driver, it is the way the flags have been set for ti,tcan1042 and
> ti,tcan1043.
I was wondering if we would enforce in the DT the 1042 has exactly one
the standby GPIO and the 1043 has exactly the standby and the enable
GPIO.
On the other hand the HW might have pulled one or the other pin high or
low and only one of the pins is connected to a GPIO.
> >> +
> >> + '#phy-cells':
> >> + const: 0
> >> +
> >> + standby-gpios:
> >> + description:
> >> + gpio node to toggle standby signal on transceiver
> >> + maxItems: 1
> >> +
> >> + enable-gpios:
> >> + description:
> >> + gpio node to toggle enable signal on transceiver
> >> + maxItems: 1
> >> +
> >> + max-bitrate:
> >> + $ref: /schemas/types.yaml#/definitions/uint32
> >> + description:
> >> + max bit rate supported in bps
> >> + minimum: 1
> >> +
> >> +required:
> >> + - compatible
> >> + - '#phy-cells'
> >> +
> >> +additionalProperties: false
> >> +
> >> +examples:
> >> + - |
> >> + #include <dt-bindings/gpio/gpio.h>
> >> +
> >> + transceiver1: tcan104x-phy {
> >> + compatible = "ti,tcan1043";
> >> + #phy-cells = <0>;
> >> + max-bitrate = <5000000>;
> >> + standby-gpios = <&wakeup_gpio1 16 GPIO_ACTIVE_LOW>;
> >> + enable-gpios = <&main_gpio1 67 GPIO_ACTIVE_LOW>;
> >
> > AFAICS the enable gpio is active high.
> >
>
> I will correct this in the respin.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Hi Aswath,
I love your patch! Perhaps something to improve:
[auto build test WARNING on mkl-can-next/testing]
[also build test WARNING on linux/master robh/for-next linus/master v5.12-rc7 next-20210414]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Aswath-Govindraju/CAN-TRANSCEIVER-Add-support-for-CAN-transceivers/20210414-220857
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git testing
config: arm64-randconfig-r012-20210415 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 6a18cc23efad410db48a3ccfc233d215de7d4cb9)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/f0bb46b67a1f6116c84a7691e05f5059377e4640
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Aswath-Govindraju/CAN-TRANSCEIVER-Add-support-for-CAN-transceivers/20210414-220857
git checkout f0bb46b67a1f6116c84a7691e05f5059377e4640
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All warnings (new ones prefixed by >>):
>> drivers/phy/phy-can-transceiver.c:79:5: warning: no previous prototype for function 'can_transceiver_phy_probe' [-Wmissing-prototypes]
int can_transceiver_phy_probe(struct platform_device *pdev)
^
drivers/phy/phy-can-transceiver.c:79:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int can_transceiver_phy_probe(struct platform_device *pdev)
^
static
1 warning generated.
vim +/can_transceiver_phy_probe +79 drivers/phy/phy-can-transceiver.c
78
> 79 int can_transceiver_phy_probe(struct platform_device *pdev)
80 {
81 struct phy_provider *phy_provider;
82 struct device *dev = &pdev->dev;
83 struct can_transceiver_phy *can_transceiver_phy;
84 const struct can_transceiver_data *drvdata;
85 const struct of_device_id *match;
86 struct phy *phy;
87 struct gpio_desc *standby_gpio;
88 struct gpio_desc *enable_gpio;
89 u32 max_bitrate = 0;
90
91 can_transceiver_phy = devm_kzalloc(dev, sizeof(struct can_transceiver_phy), GFP_KERNEL);
92 if (!can_transceiver_phy)
93 return -ENOMEM;
94
95 match = of_match_node(can_transceiver_phy_ids, pdev->dev.of_node);
96 drvdata = match->data;
97
98 phy = devm_phy_create(dev, dev->of_node,
99 &can_transceiver_phy_ops);
100 if (IS_ERR(phy)) {
101 dev_err(dev, "failed to create can transceiver phy\n");
102 return PTR_ERR(phy);
103 }
104
105 device_property_read_u32(dev, "max-bitrate", &max_bitrate);
106 if (!max_bitrate)
107 dev_warn(dev, "Invalid value for transceiver max bitrate. Ignoring bitrate limit\n");
108 phy->attrs.max_link_rate = max_bitrate;
109
110 can_transceiver_phy->generic_phy = phy;
111
112 if (drvdata->flags & CAN_TRANSCEIVER_STB_PRESENT) {
113 standby_gpio = devm_gpiod_get(dev, "standby", GPIOD_OUT_HIGH);
114 if (IS_ERR(standby_gpio))
115 return PTR_ERR(standby_gpio);
116 can_transceiver_phy->standby_gpio = standby_gpio;
117 }
118
119 if (drvdata->flags & CAN_TRANSCEIVER_EN_PRESENT) {
120 enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW);
121 if (IS_ERR(enable_gpio))
122 return PTR_ERR(enable_gpio);
123 can_transceiver_phy->enable_gpio = enable_gpio;
124 }
125
126 phy_set_drvdata(can_transceiver_phy->generic_phy, can_transceiver_phy);
127
128 phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
129
130 return PTR_ERR_OR_ZERO(phy_provider);
131 }
132
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
Hi Marc,
On 15/04/21 1:08 pm, Marc Kleine-Budde wrote:
> On 15.04.2021 11:57:20, Aswath Govindraju wrote:
>> Hi Marc,
>>
>> On 14/04/21 9:03 pm, Marc Kleine-Budde wrote:
>>> On 14.04.2021 19:35:18, Aswath Govindraju wrote:
>>>> Add binding documentation for TI TCAN104x CAN transceivers.
>>>>
>>>> Signed-off-by: Aswath Govindraju <[email protected]>
>>>> ---
>>>> .../bindings/phy/ti,tcan104x-can.yaml | 56 +++++++++++++++++++
>>>> MAINTAINERS | 1 +
>>>> 2 files changed, 57 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
>>>> new file mode 100644
>>>> index 000000000000..4abfc30a97d0
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
>>>> @@ -0,0 +1,56 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: "http://devicetree.org/schemas/phy/ti,tcan104x-can.yaml#"
>>>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>>>> +
>>>> +title: TCAN104x CAN TRANSCEIVER PHY
>>>> +
>>>> +maintainers:
>>>> + - Aswath Govindraju <[email protected]>
>
> Can you create a maintainers entry for this file with your address?
I don't see this being done for other phy yamls in the
Documentation/devicetree/bindings/phy folder. Also,
scripts/get_maintainer.pl is giving the names of maintainers after
reading the yaml files too.
Thanks,
Aswath
>
>>>> +
>>>> +properties:
>>>> + $nodename:
>>>> + pattern: "^tcan104x-phy"
>>>> +
>>>> + compatible:
>>>> + enum:
>>>> + - ti,tcan1042
>>>> + - ti,tcan1043
>>>
>>> Can you ensure that the 1042 has only the standby gpio and the 1043 has both?
>>>
>>
>> In the driver, it is the way the flags have been set for ti,tcan1042 and
>> ti,tcan1043.
>
> I was wondering if we would enforce in the DT the 1042 has exactly one
> the standby GPIO and the 1043 has exactly the standby and the enable
> GPIO.
>
> On the other hand the HW might have pulled one or the other pin high or
> low and only one of the pins is connected to a GPIO.
>
>>>> +
>>>> + '#phy-cells':
>>>> + const: 0
>>>> +
>>>> + standby-gpios:
>>>> + description:
>>>> + gpio node to toggle standby signal on transceiver
>>>> + maxItems: 1
>>>> +
>>>> + enable-gpios:
>>>> + description:
>>>> + gpio node to toggle enable signal on transceiver
>>>> + maxItems: 1
>>>> +
>>>> + max-bitrate:
>>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>>> + description:
>>>> + max bit rate supported in bps
>>>> + minimum: 1
>>>> +
>>>> +required:
>>>> + - compatible
>>>> + - '#phy-cells'
>>>> +
>>>> +additionalProperties: false
>>>> +
>>>> +examples:
>>>> + - |
>>>> + #include <dt-bindings/gpio/gpio.h>
>>>> +
>>>> + transceiver1: tcan104x-phy {
>>>> + compatible = "ti,tcan1043";
>>>> + #phy-cells = <0>;
>>>> + max-bitrate = <5000000>;
>>>> + standby-gpios = <&wakeup_gpio1 16 GPIO_ACTIVE_LOW>;
>>>> + enable-gpios = <&main_gpio1 67 GPIO_ACTIVE_LOW>;
>>>
>>> AFAICS the enable gpio is active high.
>>>
>>
>> I will correct this in the respin.
>
> Marc
>
Hi Aswath,
I love your patch! Perhaps something to improve:
[auto build test WARNING on mkl-can-next/testing]
[also build test WARNING on linux/master robh/for-next linus/master v5.12-rc7 next-20210414]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Aswath-Govindraju/CAN-TRANSCEIVER-Add-support-for-CAN-transceivers/20210414-220857
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git testing
config: m68k-randconfig-r014-20210415 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/f0bb46b67a1f6116c84a7691e05f5059377e4640
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Aswath-Govindraju/CAN-TRANSCEIVER-Add-support-for-CAN-transceivers/20210414-220857
git checkout f0bb46b67a1f6116c84a7691e05f5059377e4640
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All warnings (new ones prefixed by >>):
>> drivers/phy/phy-can-transceiver.c:79:5: warning: no previous prototype for 'can_transceiver_phy_probe' [-Wmissing-prototypes]
79 | int can_transceiver_phy_probe(struct platform_device *pdev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
vim +/can_transceiver_phy_probe +79 drivers/phy/phy-can-transceiver.c
78
> 79 int can_transceiver_phy_probe(struct platform_device *pdev)
80 {
81 struct phy_provider *phy_provider;
82 struct device *dev = &pdev->dev;
83 struct can_transceiver_phy *can_transceiver_phy;
84 const struct can_transceiver_data *drvdata;
85 const struct of_device_id *match;
86 struct phy *phy;
87 struct gpio_desc *standby_gpio;
88 struct gpio_desc *enable_gpio;
89 u32 max_bitrate = 0;
90
91 can_transceiver_phy = devm_kzalloc(dev, sizeof(struct can_transceiver_phy), GFP_KERNEL);
92 if (!can_transceiver_phy)
93 return -ENOMEM;
94
95 match = of_match_node(can_transceiver_phy_ids, pdev->dev.of_node);
96 drvdata = match->data;
97
98 phy = devm_phy_create(dev, dev->of_node,
99 &can_transceiver_phy_ops);
100 if (IS_ERR(phy)) {
101 dev_err(dev, "failed to create can transceiver phy\n");
102 return PTR_ERR(phy);
103 }
104
105 device_property_read_u32(dev, "max-bitrate", &max_bitrate);
106 if (!max_bitrate)
107 dev_warn(dev, "Invalid value for transceiver max bitrate. Ignoring bitrate limit\n");
108 phy->attrs.max_link_rate = max_bitrate;
109
110 can_transceiver_phy->generic_phy = phy;
111
112 if (drvdata->flags & CAN_TRANSCEIVER_STB_PRESENT) {
113 standby_gpio = devm_gpiod_get(dev, "standby", GPIOD_OUT_HIGH);
114 if (IS_ERR(standby_gpio))
115 return PTR_ERR(standby_gpio);
116 can_transceiver_phy->standby_gpio = standby_gpio;
117 }
118
119 if (drvdata->flags & CAN_TRANSCEIVER_EN_PRESENT) {
120 enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW);
121 if (IS_ERR(enable_gpio))
122 return PTR_ERR(enable_gpio);
123 can_transceiver_phy->enable_gpio = enable_gpio;
124 }
125
126 phy_set_drvdata(can_transceiver_phy->generic_phy, can_transceiver_phy);
127
128 phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
129
130 return PTR_ERR_OR_ZERO(phy_provider);
131 }
132
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
On 15.04.2021 14:41:57, Aswath Govindraju wrote:
> >>>> +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> > Can you create a maintainers entry for this file with your address?
>
> I don't see this being done for other phy yamls in the
> Documentation/devicetree/bindings/phy folder. Also,
> scripts/get_maintainer.pl is giving the names of maintainers after
> reading the yaml files too.
Nice! Clever script.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |