2021-04-15 09:23:57

by Jiabing Wan

Subject: [PATCH] infiniband: ulp: Remove unnecessary struct declaration

struct ipoib_cm_tx is defined at 245th line.
And the definition is independent on the MACRO.
The declaration here is unnecessary. Remove it.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/infiniband/ulp/ipoib/ipoib.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/infiniband/ulp/ipoib/ipoib.h b/drivers/infiniband/ulp/ipoib/ipoib.h
index 179ff1d068e5..d255aa69ba6d 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib.h
+++ b/drivers/infiniband/ulp/ipoib/ipoib.h
@@ -677,8 +677,6 @@ void ipoib_cm_handle_rx_wc(struct net_device *dev, struct ib_wc *wc);
void ipoib_cm_handle_tx_wc(struct net_device *dev, struct ib_wc *wc);
#else

-struct ipoib_cm_tx;
-
#define ipoib_max_conn_qp 0

static inline int ipoib_cm_admin_enabled(struct net_device *dev)
--
2.25.1

2021-04-15 09:50:58

by Christoph Lameter

Subject: Re: [PATCH] infiniband: ulp: Remove unnecessary struct declaration

On Thu, 15 Apr 2021, Wan Jiabing wrote:

> struct ipoib_cm_tx is defined at 245th line.
> And the definition is independent on the MACRO.
> The declaration here is unnecessary. Remove it.

Correct.

Reviewed-by: Christoph Lameter <[email protected]>

2021-04-20 19:11:12

by Jason Gunthorpe

Subject: Re: [PATCH] infiniband: ulp: Remove unnecessary struct declaration

On Thu, Apr 15, 2021 at 05:21:16PM +0800, Wan Jiabing wrote:
> struct ipoib_cm_tx is defined at 245th line.
> And the definition is independent on the MACRO.
> The declaration here is unnecessary. Remove it.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> Reviewed-by: Christoph Lameter <[email protected]>
> ---
> drivers/infiniband/ulp/ipoib/ipoib.h | 2 --
> 1 file changed, 2 deletions(-)

Applied to for-next, thanks

Jason