2021-04-27 17:48:56

by Iain Craig

Subject: [PATCH] staging: mt7621-pci: fix a multiple assignment code style issue

avoid multiple assignments while setting pcie->io members to NULL.

Signed-off-by: Iain Craig <[email protected]>
---
drivers/staging/mt7621-pci/pci-mt7621.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c
index 115250115f10..f3b5b8ac03b5 100644
--- a/drivers/staging/mt7621-pci/pci-mt7621.c
+++ b/drivers/staging/mt7621-pci/pci-mt7621.c
@@ -306,7 +306,9 @@ static int mt7621_pci_parse_request_of_pci_ranges(struct pci_host_bridge *host)
* resource manually instead.
*/
pcie->io.name = node->full_name;
- pcie->io.parent = pcie->io.child = pcie->io.sibling = NULL;
+ pcie->io.parent = NULL;
+ pcie->io.child = NULL;
+ pcie->io.sibling = NULL;
for_each_of_pci_range(&parser, &range) {
switch (range.flags & IORESOURCE_TYPE_BITS) {
case IORESOURCE_IO:
--
2.25.1

2021-04-27 17:59:27

by Sergio Paracuellos

Subject: Re: [PATCH] staging: mt7621-pci: fix a multiple assignment code style issue

Hi Iain.

On Tue, Apr 27, 2021 at 7:47 PM Iain Craig <[email protected]> wrote:
>
> avoid multiple assignments while setting pcie->io members to NULL.
>
> Signed-off-by: Iain Craig <[email protected]>
> ---
> drivers/staging/mt7621-pci/pci-mt7621.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c
> index 115250115f10..f3b5b8ac03b5 100644
> --- a/drivers/staging/mt7621-pci/pci-mt7621.c
> +++ b/drivers/staging/mt7621-pci/pci-mt7621.c
> @@ -306,7 +306,9 @@ static int mt7621_pci_parse_request_of_pci_ranges(struct pci_host_bridge *host)
> * resource manually instead.
> */
> pcie->io.name = node->full_name;
> - pcie->io.parent = pcie->io.child = pcie->io.sibling = NULL;
> + pcie->io.parent = NULL;
> + pcie->io.child = NULL;
> + pcie->io.sibling = NULL;

In this particular case I think the original code is correct as it is.
Also this is the style used around different kernel places to assign
these fields.

> for_each_of_pci_range(&parser, &range) {
> switch (range.flags & IORESOURCE_TYPE_BITS) {
> case IORESOURCE_IO:
> --
> 2.25.1
>

Best regards,
Sergio Paracuellos

>

2021-04-27 18:11:37

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: mt7621-pci: fix a multiple assignment code style issue

On Tue, Apr 27, 2021 at 07:55:30PM +0200, Sergio Paracuellos wrote:
> Hi Iain.
>
> On Tue, Apr 27, 2021 at 7:47 PM Iain Craig <[email protected]> wrote:
> >
> > avoid multiple assignments while setting pcie->io members to NULL.
> >
> > Signed-off-by: Iain Craig <[email protected]>
> > ---
> > drivers/staging/mt7621-pci/pci-mt7621.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c
> > index 115250115f10..f3b5b8ac03b5 100644
> > --- a/drivers/staging/mt7621-pci/pci-mt7621.c
> > +++ b/drivers/staging/mt7621-pci/pci-mt7621.c
> > @@ -306,7 +306,9 @@ static int mt7621_pci_parse_request_of_pci_ranges(struct pci_host_bridge *host)
> > * resource manually instead.
> > */
> > pcie->io.name = node->full_name;
> > - pcie->io.parent = pcie->io.child = pcie->io.sibling = NULL;
> > + pcie->io.parent = NULL;
> > + pcie->io.child = NULL;
> > + pcie->io.sibling = NULL;
>
> In this particular case I think the original code is correct as it is.
> Also this is the style used around different kernel places to assign
> these fields.

THe original is fine.

thanks,

greg k-h