2021-04-29 17:39:23

by Yu Liu

Subject: [PATCH v1] Bluetooth: Add a new MGMT error code for 0x3E HCI error

This is to enable us to retry the pairing in the user space if this
failure is encountered

Reviewed-by: Abhishek Pandit-Subedi <[email protected]>

Signed-off-by: Yu Liu <[email protected]>
---

Changes in v1:
- Initial change

include/net/bluetooth/mgmt.h | 1 +
net/bluetooth/mgmt.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
index a03c62b1dc2f..78b94577a7d8 100644
--- a/include/net/bluetooth/mgmt.h
+++ b/include/net/bluetooth/mgmt.h
@@ -45,6 +45,7 @@
#define MGMT_STATUS_RFKILLED 0x12
#define MGMT_STATUS_ALREADY_PAIRED 0x13
#define MGMT_STATUS_PERMISSION_DENIED 0x14
+#define MGMT_STATUS_CONNECT_NOT_ESTD 0x15

struct mgmt_hdr {
__le16 opcode;
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index b44e19c69c44..9e44c04d4212 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -271,7 +271,7 @@ static const u8 mgmt_status_table[] = {
MGMT_STATUS_INVALID_PARAMS, /* Unsuitable Connection Interval */
MGMT_STATUS_TIMEOUT, /* Directed Advertising Timeout */
MGMT_STATUS_AUTH_FAILED, /* Terminated Due to MIC Failure */
- MGMT_STATUS_CONNECT_FAILED, /* Connection Establishment Failed */
+ MGMT_STATUS_CONNECT_NOT_ESTD, /* Connection Establishment Failed */
MGMT_STATUS_CONNECT_FAILED, /* MAC Connection Failed */
};

--
2.31.1.527.g47e6f16901-goog

2021-05-05 16:09:23

by Yu Liu

Subject: Re: [PATCH v1] Bluetooth: Add a new MGMT error code for 0x3E HCI error

ping for attention.

On Thu, Apr 29, 2021 at 10:38 AM Yu Liu <[email protected]> wrote:
>
> This is to enable us to retry the pairing in the user space if this
> failure is encountered
>
> Reviewed-by: Abhishek Pandit-Subedi <[email protected]>
>
> Signed-off-by: Yu Liu <[email protected]>
> ---
>
> Changes in v1:
> - Initial change
>
> include/net/bluetooth/mgmt.h | 1 +
> net/bluetooth/mgmt.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
> index a03c62b1dc2f..78b94577a7d8 100644
> --- a/include/net/bluetooth/mgmt.h
> +++ b/include/net/bluetooth/mgmt.h
> @@ -45,6 +45,7 @@
> #define MGMT_STATUS_RFKILLED 0x12
> #define MGMT_STATUS_ALREADY_PAIRED 0x13
> #define MGMT_STATUS_PERMISSION_DENIED 0x14
> +#define MGMT_STATUS_CONNECT_NOT_ESTD 0x15
>
> struct mgmt_hdr {
> __le16 opcode;
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index b44e19c69c44..9e44c04d4212 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -271,7 +271,7 @@ static const u8 mgmt_status_table[] = {
> MGMT_STATUS_INVALID_PARAMS, /* Unsuitable Connection Interval */
> MGMT_STATUS_TIMEOUT, /* Directed Advertising Timeout */
> MGMT_STATUS_AUTH_FAILED, /* Terminated Due to MIC Failure */
> - MGMT_STATUS_CONNECT_FAILED, /* Connection Establishment Failed */
> + MGMT_STATUS_CONNECT_NOT_ESTD, /* Connection Establishment Failed */
> MGMT_STATUS_CONNECT_FAILED, /* MAC Connection Failed */
> };
>
> --
> 2.31.1.527.g47e6f16901-goog
>