2021-04-29 12:48:39

by Jiabing Wan

[permalink] [raw]

Subject: [PATCH] [v2] drm/amd/display: Remove duplicate declaration of dc_state

---

There are two declarations of struct dc_state here.
Remove the later duplicate more secure.

Signed-off-by: Wan Jiabing <[email protected]>
---
Changelog:
v2:
- Remove the later duplicate instead of the former.
---
drivers/gpu/drm/amd/display/dc/dc.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
index 8108b82bac60..6f3c95b5d1a2 100644
--- a/drivers/gpu/drm/amd/display/dc/dc.h
+++ b/drivers/gpu/drm/amd/display/dc/dc.h
@@ -594,7 +594,6 @@ struct dc_bounding_box_overrides {
int min_dcfclk_mhz;
};

-struct dc_state;
struct resource_pool;
struct dce_hwseq;
struct gpu_info_soc_bounding_box_v1_0;
--
2.25.1

2021-04-29 14:34:36

by Rodrigo Siqueira Jordao

[permalink] [raw]

Subject: Re: [PATCH] [v2] drm/amd/display: Remove duplicate declaration of dc_state

---

Reviewed-by: Rodrigo Siqueira <[email protected]>

On 04/29, Wan Jiabing wrote:
> There are two declarations of struct dc_state here.
> Remove the later duplicate more secure.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> Changelog:
> v2:
> - Remove the later duplicate instead of the former.
> ---
> drivers/gpu/drm/amd/display/dc/dc.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
> index 8108b82bac60..6f3c95b5d1a2 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc.h
> @@ -594,7 +594,6 @@ struct dc_bounding_box_overrides {
> int min_dcfclk_mhz;
> };
>
> -struct dc_state;
> struct resource_pool;
> struct dce_hwseq;
> struct gpu_info_soc_bounding_box_v1_0;
> --
> 2.25.1
>

--
Rodrigo Siqueira
https://siqueira.tech

---

Attachments:

(No filename) (917.00 B)
signature.asc (849.00 B)
Download all attachments

2021-04-29 14:41:10

by Rodrigo Siqueira Jordao

[permalink] [raw]

Subject: Re: [PATCH] [v2] drm/amd/display: Remove duplicate declaration of dc_state

---

Applied to amd-staging-drm-next.

Thanks

On 04/29, Rodrigo Siqueira wrote:
> Reviewed-by: Rodrigo Siqueira <[email protected]>
>
> On 04/29, Wan Jiabing wrote:
> > There are two declarations of struct dc_state here.
> > Remove the later duplicate more secure.
> >
> > Signed-off-by: Wan Jiabing <[email protected]>
> > ---
> > Changelog:
> > v2:
> > - Remove the later duplicate instead of the former.
> > ---
> > drivers/gpu/drm/amd/display/dc/dc.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
> > index 8108b82bac60..6f3c95b5d1a2 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dc.h
> > +++ b/drivers/gpu/drm/amd/display/dc/dc.h
> > @@ -594,7 +594,6 @@ struct dc_bounding_box_overrides {
> > int min_dcfclk_mhz;
> > };
> >
> > -struct dc_state;
> > struct resource_pool;
> > struct dce_hwseq;
> > struct gpu_info_soc_bounding_box_v1_0;
> > --
> > 2.25.1
> >
>
> --
> Rodrigo Siqueira
> https://siqueira.tech



--
Rodrigo Siqueira
https://siqueira.tech

---

Attachments:

(No filename) (1.09 kB)
signature.asc (849.00 B)
Download all attachments