Convert the renesas,drif binding schema to use the graph schema. The
binding referred to video-interfaces.txt, but it doesn't actually use any
properties from it as 'sync-active' is a custom property. As 'sync-active'
is custom, it needs a type definition.
Cc: Fabrizio Castro <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: Ramesh Shanmugasundaram <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Rob Herring <[email protected]>
---
.../bindings/media/renesas,drif.yaml | 20 +++++++------------
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/renesas,drif.yaml b/Documentation/devicetree/bindings/media/renesas,drif.yaml
index f1bdaeab4053..ce505a7c006a 100644
--- a/Documentation/devicetree/bindings/media/renesas,drif.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
@@ -99,32 +99,26 @@ properties:
Indicates that the channel acts as primary among the bonded channels.
port:
- type: object
+ $ref: /schemas/graph.yaml#/properties/port
+ unevaluatedProperties: false
description:
- Child port node corresponding to the data input, in accordance with the
- video interface bindings defined in
- Documentation/devicetree/bindings/media/video-interfaces.txt.
- The port node must contain at least one endpoint.
+ Child port node corresponding to the data input. The port node must
+ contain at least one endpoint.
properties:
endpoint:
- type: object
+ $ref: /schemas/graph.yaml#/$defs/endpoint-base
+ unevaluatedProperties: false
properties:
- remote-endpoint:
- description:
- A phandle to the remote tuner endpoint subnode in remote node
- port.
-
sync-active:
+ $ref: /schemas/types.yaml#/definitions/uint32
enum: [0, 1]
description:
Indicates sync signal polarity, 0/1 for low/high respectively.
This property maps to SYNCAC bit in the hardware manual. The
default is 1 (active high).
- additionalProperties: false
-
required:
- compatible
- reg
--
2.27.0
Hi Rob,
thank you for your patch.
> From: Rob Herring <[email protected]>
> Sent: 10 May 2021 21:35
> Subject: [PATCH] dt-bindings: media: renesas,drif: Use graph schema
>
> Convert the renesas,drif binding schema to use the graph schema. The
> binding referred to video-interfaces.txt, but it doesn't actually use any
> properties from it as 'sync-active' is a custom property. As 'sync-active'
> is custom, it needs a type definition.
>
> Cc: Fabrizio Castro <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>
> Cc: Ramesh Shanmugasundaram <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Rob Herring <[email protected]>
Reviewed-by: Fabrizio Castro <[email protected]>
Best regards,
Fab
> ---
> .../bindings/media/renesas,drif.yaml | 20 +++++++------------
> 1 file changed, 7 insertions(+), 13 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,drif.yaml
> b/Documentation/devicetree/bindings/media/renesas,drif.yaml
> index f1bdaeab4053..ce505a7c006a 100644
> --- a/Documentation/devicetree/bindings/media/renesas,drif.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
> @@ -99,32 +99,26 @@ properties:
> Indicates that the channel acts as primary among the bonded
> channels.
>
> port:
> - type: object
> + $ref: /schemas/graph.yaml#/properties/port
> + unevaluatedProperties: false
> description:
> - Child port node corresponding to the data input, in accordance with
> the
> - video interface bindings defined in
> - Documentation/devicetree/bindings/media/video-interfaces.txt.
> - The port node must contain at least one endpoint.
> + Child port node corresponding to the data input. The port node must
> + contain at least one endpoint.
>
> properties:
> endpoint:
> - type: object
> + $ref: /schemas/graph.yaml#/$defs/endpoint-base
> + unevaluatedProperties: false
>
> properties:
> - remote-endpoint:
> - description:
> - A phandle to the remote tuner endpoint subnode in remote
> node
> - port.
> -
> sync-active:
> + $ref: /schemas/types.yaml#/definitions/uint32
> enum: [0, 1]
> description:
> Indicates sync signal polarity, 0/1 for low/high
> respectively.
> This property maps to SYNCAC bit in the hardware manual.
> The
> default is 1 (active high).
>
> - additionalProperties: false
> -
> required:
> - compatible
> - reg
> --
> 2.27.0
On Mon, 10 May 2021 15:35:14 -0500, Rob Herring wrote:
> Convert the renesas,drif binding schema to use the graph schema. The
> binding referred to video-interfaces.txt, but it doesn't actually use any
> properties from it as 'sync-active' is a custom property. As 'sync-active'
> is custom, it needs a type definition.
>
> Cc: Fabrizio Castro <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>
> Cc: Ramesh Shanmugasundaram <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Rob Herring <[email protected]>
> ---
> .../bindings/media/renesas,drif.yaml | 20 +++++++------------
> 1 file changed, 7 insertions(+), 13 deletions(-)
>
Applied, thanks!