2021-05-11 09:26:04

by Maximilian Luz

[permalink] [raw]
Subject: [PATCH] power: supply: surface-charger: Fix type of integer variable

The ac->state field is __le32, not u32. So change the variable we're
temporarily storing it in to __le32 as well.

Reported-by: kernel test robot <[email protected]>
Fixes: e61ffb344591 ("power: supply: Add AC driver for Surface Aggregator Module")
Signed-off-by: Maximilian Luz <[email protected]>
---
drivers/power/supply/surface_charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/supply/surface_charger.c b/drivers/power/supply/surface_charger.c
index 81a5b79822c9..a060c36c7766 100644
--- a/drivers/power/supply/surface_charger.c
+++ b/drivers/power/supply/surface_charger.c
@@ -66,7 +66,7 @@ struct spwr_ac_device {

static int spwr_ac_update_unlocked(struct spwr_ac_device *ac)
{
- u32 old = ac->state;
+ __le32 old = ac->state;
int status;

lockdep_assert_held(&ac->lock);
--
2.31.1


2021-06-03 18:39:30

by Maximilian Luz

[permalink] [raw]
Subject: Re: [PATCH] power: supply: surface-charger: Fix type of integer variable

On 5/11/21 11:24 AM, Maximilian Luz wrote:
> The ac->state field is __le32, not u32. So change the variable we're
> temporarily storing it in to __le32 as well.
>
> Reported-by: kernel test robot <[email protected]>
> Fixes: e61ffb344591 ("power: supply: Add AC driver for Surface Aggregator Module")
> Signed-off-by: Maximilian Luz <[email protected]>

Friendly ping :)

> ---
> drivers/power/supply/surface_charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/surface_charger.c b/drivers/power/supply/surface_charger.c
> index 81a5b79822c9..a060c36c7766 100644
> --- a/drivers/power/supply/surface_charger.c
> +++ b/drivers/power/supply/surface_charger.c
> @@ -66,7 +66,7 @@ struct spwr_ac_device {
>
> static int spwr_ac_update_unlocked(struct spwr_ac_device *ac)
> {
> - u32 old = ac->state;
> + __le32 old = ac->state;
> int status;
>
> lockdep_assert_held(&ac->lock);
>

2021-06-04 13:02:30

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH] power: supply: surface-charger: Fix type of integer variable

Hi,

On Thu, Jun 03, 2021 at 08:37:13PM +0200, Maximilian Luz wrote:
> On 5/11/21 11:24 AM, Maximilian Luz wrote:
> > The ac->state field is __le32, not u32. So change the variable we're
> > temporarily storing it in to __le32 as well.
> >
> > Reported-by: kernel test robot <[email protected]>
> > Fixes: e61ffb344591 ("power: supply: Add AC driver for Surface Aggregator Module")
> > Signed-off-by: Maximilian Luz <[email protected]>
>
> Friendly ping :)

Thanks, this has now been queued to my fixes branch.

-- Sebastian

> > ---
> > drivers/power/supply/surface_charger.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/supply/surface_charger.c b/drivers/power/supply/surface_charger.c
> > index 81a5b79822c9..a060c36c7766 100644
> > --- a/drivers/power/supply/surface_charger.c
> > +++ b/drivers/power/supply/surface_charger.c
> > @@ -66,7 +66,7 @@ struct spwr_ac_device {
> > static int spwr_ac_update_unlocked(struct spwr_ac_device *ac)
> > {
> > - u32 old = ac->state;
> > + __le32 old = ac->state;
> > int status;
> > lockdep_assert_held(&ac->lock);
> >

Attachments:
(No filename) (1.13 kB)
 signature.asc (849.00 B)
 Download all attachments