2021-05-12 09:24:17

by Yang Yingliang

Subject: [PATCH -next] media: omap3isp: add missing unlock on error in isp_subdev_notifier_complete()

Add the missing unlock before return from isp_subdev_notifier_complete()
in the error handling case.

Fixes: ba689d933361 ("media: omap3isp: Acquire graph mutex for graph traversal")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Yang Yingliang <[email protected]>
---
drivers/media/platform/omap3isp/isp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c
index 53025c8c7531..20f59c59ff8a 100644
--- a/drivers/media/platform/omap3isp/isp.c
+++ b/drivers/media/platform/omap3isp/isp.c
@@ -2037,8 +2037,10 @@ static int isp_subdev_notifier_complete(struct v4l2_async_notifier *async)
mutex_lock(&isp->media_dev.graph_mutex);

ret = media_entity_enum_init(&isp->crashed, &isp->media_dev);
- if (ret)
+ if (ret) {
+ mutex_unlock(&isp->media_dev.graph_mutex);
return ret;
+ }

list_for_each_entry(sd, &v4l2_dev->subdevs, list) {
if (sd->notifier != &isp->notifier)
--
2.25.1

2021-06-23 23:09:27

by Sakari Ailus

Subject: Re: [PATCH -next] media: omap3isp: add missing unlock on error in isp_subdev_notifier_complete()

Hi Yang,

On Wed, May 12, 2021 at 05:23:01PM +0800, Yang Yingliang wrote:
> Add the missing unlock before return from isp_subdev_notifier_complete()
> in the error handling case.
>
> Fixes: ba689d933361 ("media: omap3isp: Acquire graph mutex for graph traversal")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Yang Yingliang <[email protected]>

Thanks for the patch. This is already fixed by another patch, accidentally
left sitting in my tree... It'll be in the next pull request.

<URL:https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/>

--
Sakari Ailus