2021-05-16 09:24:07

by Andreas Kemnade

Subject: [PATCH RESEND] mfd: rn5t618: fix IRQ trigger by changing it to level mode

During more massive generation of interrupts, the IRQ got stuck,
and the subdevices did not see any new interrupts. That happens
especially at wonky USB supply in combination with ADC reads.
To fix that trigger the IRQ at level low instead of falling edge.

Fixes: 0c81604516af ("mfd: rn5t618: Add IRQ support")
Signed-off-by: Andreas Kemnade <[email protected]>
---
drivers/mfd/rn5t618.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c
index ecddd7b6500e..a852eef1f4d2 100644
--- a/drivers/mfd/rn5t618.c
+++ b/drivers/mfd/rn5t618.c
@@ -109,7 +109,7 @@ static int rn5t618_irq_init(struct rn5t618 *rn5t618)

ret = devm_regmap_add_irq_chip(rn5t618->dev, rn5t618->regmap,
rn5t618->irq,
- IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+ IRQF_TRIGGER_LOW | IRQF_ONESHOT,
0, irq_chip, &rn5t618->irq_data);
if (ret)
dev_err(rn5t618->dev, "Failed to register IRQ chip\n");
--
2.29.2

2021-05-19 20:11:26

by Lee Jones

Subject: Re: [PATCH RESEND] mfd: rn5t618: fix IRQ trigger by changing it to level mode

On Sat, 15 May 2021, Andreas Kemnade wrote:

> During more massive generation of interrupts, the IRQ got stuck,
> and the subdevices did not see any new interrupts. That happens
> especially at wonky USB supply in combination with ADC reads.
> To fix that trigger the IRQ at level low instead of falling edge.
>
> Fixes: 0c81604516af ("mfd: rn5t618: Add IRQ support")
> Signed-off-by: Andreas Kemnade <[email protected]>
> ---
> drivers/mfd/rn5t618.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog