2021-05-28 10:00:29

by Moriis Ku

Subject: [PATCH] mfd:Add supprt for SUNIX mfd & PCIe driver

From: Morris Ku <[email protected]>

Add support for SUNIX mfd & PCIe driver

Cc: Jason Lee <[email protected]>
Cc: Taian Chen <[email protected]>
Signed-off-by: Morris Ku <[email protected]>
---
Kconfig | 12 ++++++++++++
Makefile | 4 ++++
2 files changed, 16 insertions(+)

diff --git a/Kconfig b/Kconfig
index 17d0ad2..25b7db5 100644
--- a/Kconfig
+++ b/Kconfig
@@ -2012,6 +2012,18 @@ config RAVE_SP_CORE
Select this to get support for the Supervisory Processor
device found on several devices in RAVE line of hardware.

+config MFD_SUNIX_SDC
+ tristate
+ select MFD_CORE
+ select SERIAL_8250_SDC
+
+config MFD_SUNIX_SDC_PCI
+ tristate "SUNIX SDC PCIe multi-function board support"
+ select MFD_SUNIX_SDC
+ depends on X86 && PCI
+ help
+ Selecting this option will add support for SUNIX SDC PCIe
+ multi-function board.

endmenu
endif
diff --git a/Makefile b/Makefile
index a1872e4..52fa8be 100644
--- a/Makefile
+++ b/Makefile
@@ -256,4 +256,8 @@ obj-$(CONFIG_MFD_ROHM_BD70528) += rohm-bd70528.o
obj-$(CONFIG_MFD_ROHM_BD718XX) += rohm-bd718x7.o
obj-$(CONFIG_MFD_STMFX) += stmfx.o

+obj-$(CONFIG_MFD_SUNIX_SDC) += sdc_mfd.o
+obj-$(CONFIG_MFD_SUNIX_SDC_PCI) += sdc_pci.o
+
+

--
2.20.1

2021-06-01 09:10:20

by Lee Jones

Subject: Re: [PATCH] mfd:Add supprt for SUNIX mfd & PCIe driver

On Fri, 28 May 2021, Moriis Ku wrote:

> From: Morris Ku <[email protected]>
>
> Add support for SUNIX mfd & PCIe driver

That's a pretty broad description.


> Cc: Jason Lee <[email protected]>
> Cc: Taian Chen <[email protected]>
> Signed-off-by: Morris Ku <[email protected]>
> ---
> Kconfig | 12 ++++++++++++
> Makefile | 4 ++++
> 2 files changed, 16 insertions(+)

Patches should be generated from the root of the source directory.

> diff --git a/Kconfig b/Kconfig
> index 17d0ad2..25b7db5 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -2012,6 +2012,18 @@ config RAVE_SP_CORE
> Select this to get support for the Supervisory Processor
> device found on several devices in RAVE line of hardware.
>
> +config MFD_SUNIX_SDC
> + tristate
> + select MFD_CORE
> + select SERIAL_8250_SDC
> +
> +config MFD_SUNIX_SDC_PCI
> + tristate "SUNIX SDC PCIe multi-function board support"

What is SDC?

> + select MFD_SUNIX_SDC
> + depends on X86 && PCI
> + help
> + Selecting this option will add support for SUNIX SDC PCIe
> + multi-function board.

More please.

> endmenu
> endif
> diff --git a/Makefile b/Makefile
> index a1872e4..52fa8be 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -256,4 +256,8 @@ obj-$(CONFIG_MFD_ROHM_BD70528) += rohm-bd70528.o
> obj-$(CONFIG_MFD_ROHM_BD718XX) += rohm-bd718x7.o
> obj-$(CONFIG_MFD_STMFX) += stmfx.o
>
> +obj-$(CONFIG_MFD_SUNIX_SDC) += sdc_mfd.o

There is no such thing as MFD.

You probably mean 'core'.

> +obj-$(CONFIG_MFD_SUNIX_SDC_PCI) += sdc_pci.o
> +
> +

No need for 2 empty spaces.

This patch doesn't actually do anything.

Please submit it squashed into the driver.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog