2021-06-02 12:06:24

by J. Neuschäfer

[permalink] [raw]
Subject: [PATCH 3/8] ARM: dts: wpcm450: Add global control registers (GCR) node

The Global Control Registers (GCR) are a block of registers in Nuvoton
SoCs that expose misc functionality such as chip model and version
information or pinmux settings.

This patch adds a GCR node to nuvoton-wpcm450.dtsi in preparation for
enabling pinctrl on this SoC.

Signed-off-by: Jonathan Neuschäfer <[email protected]>
---
arch/arm/boot/dts/nuvoton-wpcm450.dtsi | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
index d7cbeb1874840..8eba4897b41bc 100644
--- a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
+++ b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
@@ -33,6 +33,11 @@ soc {
interrupt-parent = <&aic>;
ranges;

+ gcr: gcr@b0000000 {
+ compatible = "nuvoton,wpcm450-gcr", "syscon", "simple-mfd";
+ reg = <0xb0000000 0x200>;
+ };
+
serial0: serial@b8000000 {
compatible = "nuvoton,wpcm450-uart";
reg = <0xb8000000 0x20>;
--
2.30.2


2021-06-04 08:02:50

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 3/8] ARM: dts: wpcm450: Add global control registers (GCR) node

On Wed, Jun 2, 2021 at 2:04 PM Jonathan Neuschäfer
<[email protected]> wrote:

> The Global Control Registers (GCR) are a block of registers in Nuvoton
> SoCs that expose misc functionality such as chip model and version
> information or pinmux settings.
>
> This patch adds a GCR node to nuvoton-wpcm450.dtsi in preparation for
> enabling pinctrl on this SoC.
>
> Signed-off-by: Jonathan Neuschäfer <[email protected]>

As noted I would name this architecture-neutral with
syscon@...

Yours,
Linus Walleij

2021-06-13 09:25:08

by J. Neuschäfer

[permalink] [raw]
Subject: Re: [PATCH 3/8] ARM: dts: wpcm450: Add global control registers (GCR) node

On Fri, Jun 04, 2021 at 10:01:07AM +0200, Linus Walleij wrote:
> On Wed, Jun 2, 2021 at 2:04 PM Jonathan Neuschäfer
> <[email protected]> wrote:
>
> > The Global Control Registers (GCR) are a block of registers in Nuvoton
> > SoCs that expose misc functionality such as chip model and version
> > information or pinmux settings.
> >
> > This patch adds a GCR node to nuvoton-wpcm450.dtsi in preparation for
> > enabling pinctrl on this SoC.
> >
> > Signed-off-by: Jonathan Neuschäfer <[email protected]>
>
> As noted I would name this architecture-neutral with
> syscon@...

Will do.


Jonathan Neuschäfer


Attachments:
(No filename) (639.00 B)
signature.asc (849.00 B)
Download all attachments