2021-06-09 17:12:52

by Icenowy Zheng

[permalink] [raw]
Subject: [PATCH] arm64: dts: allwinner: a64-sopine-baseboard: change RGMII mode to TXID

Although the schematics of Pine A64-LTS and SoPine Baseboard shows both
the RX and TX internal delay are enabled, they're using the same broken
RTL8211E chip batch with Pine A64+, so they should use TXID instead, not
ID.

In addition, by checking the real components soldered on both a SoPine
Baseboard and a Pine A64-LTS, RX delay is not enabled (GR69 soldered and
GR70 NC) despite the schematics says it's enabled. It's a common
situation for Pine64 boards that the NC information on schematics is not
the same with the board.

So the RGMII delay mode should be TXID on these boards.

Fixes: c2b111e59a7b ("arm64: dts: allwinner: A64 Sopine: phy-mode rgmii-id")
Signed-off-by: Icenowy Zheng <[email protected]>
---
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
index e22b94c83647..5e66ce1a334f 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
@@ -79,7 +79,7 @@ &ehci1 {
&emac {
pinctrl-names = "default";
pinctrl-0 = <&rgmii_pins>;
- phy-mode = "rgmii-id";
+ phy-mode = "rgmii-txid";
phy-handle = <&ext_rgmii_phy>;
phy-supply = <&reg_dc1sw>;
status = "okay";
--
2.30.2


2021-06-10 12:55:39

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: allwinner: a64-sopine-baseboard: change RGMII mode to TXID

On Wed, Jun 09, 2021 at 04:38:43PM +0800, Icenowy Zheng wrote:
> Although the schematics of Pine A64-LTS and SoPine Baseboard shows both
> the RX and TX internal delay are enabled, they're using the same broken
> RTL8211E chip batch with Pine A64+, so they should use TXID instead, not
> ID.
>
> In addition, by checking the real components soldered on both a SoPine
> Baseboard and a Pine A64-LTS, RX delay is not enabled (GR69 soldered and
> GR70 NC) despite the schematics says it's enabled. It's a common
> situation for Pine64 boards that the NC information on schematics is not
> the same with the board.
>
> So the RGMII delay mode should be TXID on these boards.
>
> Fixes: c2b111e59a7b ("arm64: dts: allwinner: A64 Sopine: phy-mode rgmii-id")
> Signed-off-by: Icenowy Zheng <[email protected]>

Applied, thanks
Maxime

Attachments:
(No filename) (847.00 B)
 signature.asc (235.00 B)
 Download all attachments