2021-06-04 16:07:42

by Arnaud Pouliquen

Subject: [PATCH] rpmsg: Fix rpmsg_create_ept return when RPMSG config is not defined

This is a minor fix.

According to the description of the rpmsg_create_ept in rpmsg_core.c
the function should return NULL on error.

Signed-off-by: Arnaud Pouliquen <[email protected]>
---
include/linux/rpmsg.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/rpmsg.h b/include/linux/rpmsg.h
index d97dcd049f18..a8dcf8a9ae88 100644
--- a/include/linux/rpmsg.h
+++ b/include/linux/rpmsg.h
@@ -231,7 +231,7 @@ static inline struct rpmsg_endpoint *rpmsg_create_ept(struct rpmsg_device *rpdev
/* This shouldn't be possible */
WARN_ON(1);

- return ERR_PTR(-ENXIO);
+ return NULL;
}

static inline int rpmsg_send(struct rpmsg_endpoint *ept, void *data, int len)
--
2.17.1

2021-06-10 17:12:18

by Mathieu Poirier

Subject: Re: [PATCH] rpmsg: Fix rpmsg_create_ept return when RPMSG config is not defined

On Fri, Jun 04, 2021 at 06:05:49PM +0200, Arnaud Pouliquen wrote:
> This is a minor fix.
>
> According to the description of the rpmsg_create_ept in rpmsg_core.c
> the function should return NULL on error.
>

You are correct, and none of the client return an error code either.

> Signed-off-by: Arnaud Pouliquen <[email protected]>
> ---
> include/linux/rpmsg.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/rpmsg.h b/include/linux/rpmsg.h
> index d97dcd049f18..a8dcf8a9ae88 100644
> --- a/include/linux/rpmsg.h
> +++ b/include/linux/rpmsg.h
> @@ -231,7 +231,7 @@ static inline struct rpmsg_endpoint *rpmsg_create_ept(struct rpmsg_device *rpdev
> /* This shouldn't be possible */
> WARN_ON(1);
>
> - return ERR_PTR(-ENXIO);
> + return NULL;

Reviewed-by: Mathieu Poirier <[email protected]>

> }
>
> static inline int rpmsg_send(struct rpmsg_endpoint *ept, void *data, int len)
> --
> 2.17.1
>