2021-05-28 02:11:25

by Andreas Kemnade

[permalink] [raw]
Subject: [PATCH] ARM: dts: imx6sl: add PXP module

While the EPDC is optional, all editions have the PXP module, so adding
it to the corresponding .dtsi
Information taken from freescale kernel, compared with the
reference manual and tested by a separate program.

Since it does not depend on external wiring, the
status = "disabled" is left out here.

Signed-off-by: Andreas Kemnade <[email protected]>
---
arch/arm/boot/dts/imx6sl.dtsi | 3 +++
1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
index 997b96c1c47b..6be83e863f19 100644
--- a/arch/arm/boot/dts/imx6sl.dtsi
+++ b/arch/arm/boot/dts/imx6sl.dtsi
@@ -762,8 +762,11 @@
};

pxp: pxp@20f0000 {
+ compatible = "fsl,imx6sl-pxp", "fsl,imx6ull-pxp";
reg = <0x020f0000 0x4000>;
interrupts = <0 98 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clks IMX6SL_CLK_PXP_AXI>;
+ clock-names = "axi";
};

epdc: epdc@20f4000 {
--
2.20.1


2021-06-12 07:08:45

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: imx6sl: add PXP module

On Thu, May 27, 2021 at 11:07:42PM +0200, Andreas Kemnade wrote:
> While the EPDC is optional, all editions have the PXP module, so adding
> it to the corresponding .dtsi
> Information taken from freescale kernel, compared with the
> reference manual and tested by a separate program.
>
> Since it does not depend on external wiring, the
> status = "disabled" is left out here.
>
> Signed-off-by: Andreas Kemnade <[email protected]>
> ---
> arch/arm/boot/dts/imx6sl.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> index 997b96c1c47b..6be83e863f19 100644
> --- a/arch/arm/boot/dts/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/imx6sl.dtsi
> @@ -762,8 +762,11 @@
> };
>
> pxp: pxp@20f0000 {
> + compatible = "fsl,imx6sl-pxp", "fsl,imx6ull-pxp";

"fsl,imx6sl-pxp" needs to be documented.

Shawn

> reg = <0x020f0000 0x4000>;
> interrupts = <0 98 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clks IMX6SL_CLK_PXP_AXI>;
> + clock-names = "axi";
> };
>
> epdc: epdc@20f4000 {
> --
> 2.20.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel