2021-06-17 02:45:30

by Pu Lehui

Subject: [PATCH -next] drm/amd/display: remove unused variable 'dc'

GCC reports the following warning with W=1:

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_psr.c:70:13:
warning:
variable ‘dc’ set but not used [-Wunused-but-set-variable]
70 | struct dc *dc = NULL;
| ^~

This variable is not used in function, this commit remove it to
fix the warning.

Signed-off-by: Pu Lehui <[email protected]>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
index f7c77ae0d965..70a554f1e725 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
@@ -67,14 +67,12 @@ bool amdgpu_dm_link_setup_psr(struct dc_stream_state *stream)
struct dc_link *link = NULL;
struct psr_config psr_config = {0};
struct psr_context psr_context = {0};
- struct dc *dc = NULL;
bool ret = false;

if (stream == NULL)
return false;

link = stream->link;
- dc = link->ctx->dc;

psr_config.psr_version = link->dpcd_caps.psr_caps.psr_version;

--
2.17.1

2021-06-17 20:47:20

by Harry Wentland

Subject: Re: [PATCH -next] drm/amd/display: remove unused variable 'dc'

On 2021-06-16 9:16 p.m., Pu Lehui wrote:
> GCC reports the following warning with W=1:
>
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_psr.c:70:13:
> warning:
> variable ‘dc’ set but not used [-Wunused-but-set-variable]
> 70 | struct dc *dc = NULL;
> | ^~
>
> This variable is not used in function, this commit remove it to
> fix the warning.
>
> Signed-off-by: Pu Lehui <[email protected]>

Reviewed-by: Harry Wentland <[email protected]>

Harry

> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> index f7c77ae0d965..70a554f1e725 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> @@ -67,14 +67,12 @@ bool amdgpu_dm_link_setup_psr(struct dc_stream_state *stream)
> struct dc_link *link = NULL;
> struct psr_config psr_config = {0};
> struct psr_context psr_context = {0};
> - struct dc *dc = NULL;
> bool ret = false;
>
> if (stream == NULL)
> return false;
>
> link = stream->link;
> - dc = link->ctx->dc;
>
> psr_config.psr_version = link->dpcd_caps.psr_caps.psr_version;
>
>

2021-06-19 03:51:03

by Alex Deucher

Subject: Re: [PATCH -next] drm/amd/display: remove unused variable 'dc'

Applied. Thanks!

On Thu, Jun 17, 2021 at 3:04 PM Harry Wentland <[email protected]> wrote:
>
>
>
> On 2021-06-16 9:16 p.m., Pu Lehui wrote:
> > GCC reports the following warning with W=1:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_psr.c:70:13:
> > warning:
> > variable ‘dc’ set but not used [-Wunused-but-set-variable]
> > 70 | struct dc *dc = NULL;
> > | ^~
> >
> > This variable is not used in function, this commit remove it to
> > fix the warning.
> >
> > Signed-off-by: Pu Lehui <[email protected]>
>
> Reviewed-by: Harry Wentland <[email protected]>
>
> Harry
>
> > ---
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> > index f7c77ae0d965..70a554f1e725 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> > @@ -67,14 +67,12 @@ bool amdgpu_dm_link_setup_psr(struct dc_stream_state *stream)
> > struct dc_link *link = NULL;
> > struct psr_config psr_config = {0};
> > struct psr_context psr_context = {0};
> > - struct dc *dc = NULL;
> > bool ret = false;
> >
> > if (stream == NULL)
> > return false;
> >
> > link = stream->link;
> > - dc = link->ctx->dc;
> >
> > psr_config.psr_version = link->dpcd_caps.psr_caps.psr_version;
> >
> >
>
> _______________________________________________
> amd-gfx mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx