2021-06-29 09:44:29

by Harini Katakam

Subject: [PATCH 1/3] include: dt-bindings: Add mscc-vsc8531 RGMII clock delay definitions

Add RGMII clock delay definitions in mscc-phy-vsc8531 header.

Signed-off-by: Harini Katakam <[email protected]>
Signed-off-by: Radhey Shyam Pandey <[email protected]>
Signed-off-by: Michal Simek <[email protected]>
---
include/dt-bindings/net/mscc-phy-vsc8531.h | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/include/dt-bindings/net/mscc-phy-vsc8531.h b/include/dt-bindings/net/mscc-phy-vsc8531.h
index 9eb2ec2b2ea9..242eb4c7ede9 100644
--- a/include/dt-bindings/net/mscc-phy-vsc8531.h
+++ b/include/dt-bindings/net/mscc-phy-vsc8531.h
@@ -28,4 +28,13 @@
#define VSC8531_FORCE_LED_OFF 14
#define VSC8531_FORCE_LED_ON 15

+#define VSC8531_RGMII_CLK_DELAY_0_2_NS 0
+#define VSC8531_RGMII_CLK_DELAY_0_8_NS 1
+#define VSC8531_RGMII_CLK_DELAY_1_1_NS 2
+#define VSC8531_RGMII_CLK_DELAY_1_7_NS 3
+#define VSC8531_RGMII_CLK_DELAY_2_0_NS 4
+#define VSC8531_RGMII_CLK_DELAY_2_3_NS 5
+#define VSC8531_RGMII_CLK_DELAY_2_6_NS 6
+#define VSC8531_RGMII_CLK_DELAY_3_4_NS 7
+
#endif
--
2.17.1

2021-06-29 14:00:47

by Andrew Lunn

Subject: Re: [PATCH 1/3] include: dt-bindings: Add mscc-vsc8531 RGMII clock delay definitions

On Tue, Jun 29, 2021 at 03:10:36PM +0530, Harini Katakam wrote:
> Add RGMII clock delay definitions in mscc-phy-vsc8531 header.
>
> Signed-off-by: Harini Katakam <[email protected]>
> Signed-off-by: Radhey Shyam Pandey <[email protected]>
> Signed-off-by: Michal Simek <[email protected]>
> ---
> include/dt-bindings/net/mscc-phy-vsc8531.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/include/dt-bindings/net/mscc-phy-vsc8531.h b/include/dt-bindings/net/mscc-phy-vsc8531.h
> index 9eb2ec2b2ea9..242eb4c7ede9 100644
> --- a/include/dt-bindings/net/mscc-phy-vsc8531.h
> +++ b/include/dt-bindings/net/mscc-phy-vsc8531.h
> @@ -28,4 +28,13 @@
> #define VSC8531_FORCE_LED_OFF 14
> #define VSC8531_FORCE_LED_ON 15
>
> +#define VSC8531_RGMII_CLK_DELAY_0_2_NS 0
> +#define VSC8531_RGMII_CLK_DELAY_0_8_NS 1
> +#define VSC8531_RGMII_CLK_DELAY_1_1_NS 2
> +#define VSC8531_RGMII_CLK_DELAY_1_7_NS 3
> +#define VSC8531_RGMII_CLK_DELAY_2_0_NS 4
> +#define VSC8531_RGMII_CLK_DELAY_2_3_NS 5
> +#define VSC8531_RGMII_CLK_DELAY_2_6_NS 6
> +#define VSC8531_RGMII_CLK_DELAY_3_4_NS 7

Using defines like this is no longer used. Please specify the delay in
pS and convert to a register value within the driver.

Andrew