2021-06-29 11:38:12

by Jing Xiangfeng

Subject: [PATCH -next] drm/radeon: Add the missed drm_gem_object_put() in radeon_user_framebuffer_create()

radeon_user_framebuffer_create() misses to call drm_gem_object_put() in
an error path. Add the missed function call to fix it.

Signed-off-by: Jing Xiangfeng <[email protected]>
---
drivers/gpu/drm/radeon/radeon_display.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
index 652af7a134bd..1d03ec763604 100644
--- a/drivers/gpu/drm/radeon/radeon_display.c
+++ b/drivers/gpu/drm/radeon/radeon_display.c
@@ -1325,6 +1325,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
/* Handle is imported dma-buf, so cannot be migrated to VRAM for scanout */
if (obj->import_attach) {
DRM_DEBUG_KMS("Cannot create framebuffer from imported dma_buf\n");
+ drm_gem_object_put(obj);
return ERR_PTR(-EINVAL);
}

--
2.26.0.106.g9fadedd

2021-06-29 11:43:20

by Christian König

Subject: Re: [PATCH -next] drm/radeon: Add the missed drm_gem_object_put() in radeon_user_framebuffer_create()

Am 29.06.21 um 13:44 schrieb Jing Xiangfeng:
> radeon_user_framebuffer_create() misses to call drm_gem_object_put() in
> an error path. Add the missed function call to fix it.
>
> Signed-off-by: Jing Xiangfeng <[email protected]>

I'm pretty sure that I already reviewed the same patch a few weeks ago,
but it looks like it never went upstream.

Reviewed-by: Christian König <[email protected]>

Maybe add CC: stable as well?

Regards,
Christian.

> ---
> drivers/gpu/drm/radeon/radeon_display.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> index 652af7a134bd..1d03ec763604 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -1325,6 +1325,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
> /* Handle is imported dma-buf, so cannot be migrated to VRAM for scanout */
> if (obj->import_attach) {
> DRM_DEBUG_KMS("Cannot create framebuffer from imported dma_buf\n");
> + drm_gem_object_put(obj);
> return ERR_PTR(-EINVAL);
> }
>

2021-06-29 14:22:02

by Alex Deucher

Subject: Re: [PATCH -next] drm/radeon: Add the missed drm_gem_object_put() in radeon_user_framebuffer_create()

Applied. Thanks!

Alex

On Tue, Jun 29, 2021 at 7:42 AM Christian König
<[email protected]> wrote:
>
> Am 29.06.21 um 13:44 schrieb Jing Xiangfeng:
> > radeon_user_framebuffer_create() misses to call drm_gem_object_put() in
> > an error path. Add the missed function call to fix it.
> >
> > Signed-off-by: Jing Xiangfeng <[email protected]>
>
> I'm pretty sure that I already reviewed the same patch a few weeks ago,
> but it looks like it never went upstream.
>
> Reviewed-by: Christian König <[email protected]>
>
> Maybe add CC: stable as well?
>
> Regards,
> Christian.
>
> > ---
> > drivers/gpu/drm/radeon/radeon_display.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> > index 652af7a134bd..1d03ec763604 100644
> > --- a/drivers/gpu/drm/radeon/radeon_display.c
> > +++ b/drivers/gpu/drm/radeon/radeon_display.c
> > @@ -1325,6 +1325,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
> > /* Handle is imported dma-buf, so cannot be migrated to VRAM for scanout */
> > if (obj->import_attach) {
> > DRM_DEBUG_KMS("Cannot create framebuffer from imported dma_buf\n");
> > + drm_gem_object_put(obj);
> > return ERR_PTR(-EINVAL);
> > }
> >
>
> _______________________________________________
> amd-gfx mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx