2021-06-29 12:52:23

by Anand Moon

[permalink] [raw]
Subject: [PATCHv1] arm64: amlogic: Fix the pwm regulator supply property in node

On enable CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
Changes help link VDDCPU_A and VDDCPU_B pwm regulator to 12V regulator
supply instead of dummy regulator.

[ 4.147196] VDDCPU_A: will resolve supply early: pwm
[ 4.147216] pwm-regulator regulator-vddcpu-a: Looking up pwm-supply from device tree
[ 4.147227] pwm-regulator regulator-vddcpu-a: Looking up pwm-supply property in node /regulator-vddcpu-a failed
[ 4.147258] VDDCPU_A: supplied by regulator-dummy
[ 4.147288] regulator-dummy: could not add device link regulator.12: -ENOENT
[ 4.147353] VDDCPU_A: 721 <--> 1022 mV at 871 mV, enabled
[ 4.152014] VDDCPU_B: will resolve supply early: pwm
[ 4.152035] pwm-regulator regulator-vddcpu-b: Looking up pwm-supply from device tree
[ 4.152047] pwm-regulator regulator-vddcpu-b: Looking up pwm-supply property in node /regulator-vddcpu-b failed
[ 4.152079] VDDCPU_B: supplied by regulator-dummy
[ 4.152108] regulator-dummy: could not add device link regulator.13: -ENOENT

Fixes: d14734a04a8a ("arm64: dts: meson-g12b-odroid-n2: enable DVFS")

Cc: Neil Armstrong <[email protected]>
Signed-off-by: Anand Moon <[email protected]>
---
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
index 344573e157a7..4f33820aba1f 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
@@ -130,7 +130,7 @@ vddcpu_a: regulator-vddcpu-a {
regulator-min-microvolt = <721000>;
regulator-max-microvolt = <1022000>;

- vin-supply = <&main_12v>;
+ pwm-supply = <&main_12v>;

pwms = <&pwm_ab 0 1250 0>;
pwm-dutycycle-range = <100 0>;
@@ -149,7 +149,7 @@ vddcpu_b: regulator-vddcpu-b {
regulator-min-microvolt = <721000>;
regulator-max-microvolt = <1022000>;

- vin-supply = <&main_12v>;
+ pwm-supply = <&main_12v>;

pwms = <&pwm_AO_cd 1 1250 0>;
pwm-dutycycle-range = <100 0>;
--
2.31.1


2021-06-29 16:12:00

by Martin Blumenstingl

[permalink] [raw]
Subject: Re: [PATCHv1] arm64: amlogic: Fix the pwm regulator supply property in node

Hi Anand,

thanks for investigating this and for sending a fix!

On Tue, Jun 29, 2021 at 2:19 PM Anand Moon <[email protected]> wrote:
>
> On enable CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
see my comment on the previous patch

> Changes help link VDDCPU_A and VDDCPU_B pwm regulator to 12V regulator
> supply instead of dummy regulator.
>
> [ 4.147196] VDDCPU_A: will resolve supply early: pwm
> [ 4.147216] pwm-regulator regulator-vddcpu-a: Looking up pwm-supply from device tree
> [ 4.147227] pwm-regulator regulator-vddcpu-a: Looking up pwm-supply property in node /regulator-vddcpu-a failed
> [ 4.147258] VDDCPU_A: supplied by regulator-dummy
> [ 4.147288] regulator-dummy: could not add device link regulator.12: -ENOENT
> [ 4.147353] VDDCPU_A: 721 <--> 1022 mV at 871 mV, enabled
> [ 4.152014] VDDCPU_B: will resolve supply early: pwm
> [ 4.152035] pwm-regulator regulator-vddcpu-b: Looking up pwm-supply from device tree
> [ 4.152047] pwm-regulator regulator-vddcpu-b: Looking up pwm-supply property in node /regulator-vddcpu-b failed
> [ 4.152079] VDDCPU_B: supplied by regulator-dummy
> [ 4.152108] regulator-dummy: could not add device link regulator.13: -ENOENT
>
> Fixes: d14734a04a8a ("arm64: dts: meson-g12b-odroid-n2: enable DVFS")
I suggest changing the subject to include "dts", for example:
arm64: dts: amlogic: ...
(note: lower-case arm64 is correct here - even though it's different
from the 32-bit ARM prefix)

$ grep -lR pwm-regulator arch/arm64/boot/dts/amlogic/
arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts
arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi
arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi
arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi
Are you planning to also send patches for the other board .dts as well?


Best regards,
Martin