2021-07-02 19:12:56

by Atish Patra

Subject: [PATCH] efi/libstub: Fix the efi_load_initrd function description

The soft_limit and hard_limit in the function efi_load_initrd describes
the preferred and max address of initrd loading location respectively.
However, the description wrongly describes it as the size of the
allocated memory.

Fix the function description.

Signed-off-by: Atish Patra <[email protected]>
---
drivers/firmware/efi/libstub/efi-stub-helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/efi/libstub/efi-stub-helper.c b/drivers/firmware/efi/libstub/efi-stub-helper.c
index aa8da0a49829..ae87dded989d 100644
--- a/drivers/firmware/efi/libstub/efi-stub-helper.c
+++ b/drivers/firmware/efi/libstub/efi-stub-helper.c
@@ -630,8 +630,8 @@ efi_status_t efi_load_initrd_cmdline(efi_loaded_image_t *image,
* @image: EFI loaded image protocol
* @load_addr: pointer to loaded initrd
* @load_size: size of loaded initrd
- * @soft_limit: preferred size of allocated memory for loading the initrd
- * @hard_limit: minimum size of allocated memory
+ * @soft_limit: preferred address for loading the initrd
+ * @hard_limit: upper limit address for loading the initrd
*
* Return: status code
*/
--
2.31.1

2021-07-16 16:19:49

by Ard Biesheuvel

Subject: Re: [PATCH] efi/libstub: Fix the efi_load_initrd function description

On Fri, 2 Jul 2021 at 21:10, Atish Patra <[email protected]> wrote:
>
> The soft_limit and hard_limit in the function efi_load_initrd describes
> the preferred and max address of initrd loading location respectively.
> However, the description wrongly describes it as the size of the
> allocated memory.
>
> Fix the function description.
>
> Signed-off-by: Atish Patra <[email protected]>

Now queued up, thanks.

> ---
> drivers/firmware/efi/libstub/efi-stub-helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/efi/libstub/efi-stub-helper.c b/drivers/firmware/efi/libstub/efi-stub-helper.c
> index aa8da0a49829..ae87dded989d 100644
> --- a/drivers/firmware/efi/libstub/efi-stub-helper.c
> +++ b/drivers/firmware/efi/libstub/efi-stub-helper.c
> @@ -630,8 +630,8 @@ efi_status_t efi_load_initrd_cmdline(efi_loaded_image_t *image,
> * @image: EFI loaded image protocol
> * @load_addr: pointer to loaded initrd
> * @load_size: size of loaded initrd
> - * @soft_limit: preferred size of allocated memory for loading the initrd
> - * @hard_limit: minimum size of allocated memory
> + * @soft_limit: preferred address for loading the initrd
> + * @hard_limit: upper limit address for loading the initrd
> *
> * Return: status code
> */
> --
> 2.31.1
>