2021-07-12 14:53:30

by Colin King

Subject: [PATCH] mtd: devices: mchp48l640: Fix memory leak on cmd

From: Colin Ian King <[email protected]>

The allocation for cmd is not being kfree'd on the return leading to
a memory leak. Fix this by kfree'ing it.

Addresses-Coverity: ("Resource leak")
Fixes: 88d125026753 ("mtd: devices: add support for microchip 48l640 EERAM")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/mtd/devices/mchp48l640.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/devices/mchp48l640.c b/drivers/mtd/devices/mchp48l640.c
index efc2003bd13a..c0b1a7bb7d13 100644
--- a/drivers/mtd/devices/mchp48l640.c
+++ b/drivers/mtd/devices/mchp48l640.c
@@ -255,6 +255,7 @@ static int mchp48l640_read_page(struct mtd_info *mtd, loff_t from, size_t len,
if (!ret)
*retlen += len;

+ kfree(cmd);
return ret;

fail:
--
2.31.1

2021-07-15 22:51:14

by Miquel Raynal

Subject: Re: [PATCH] mtd: devices: mchp48l640: Fix memory leak on cmd

On Mon, 2021-07-12 at 14:52:14 UTC, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The allocation for cmd is not being kfree'd on the return leading to
> a memory leak. Fix this by kfree'ing it.
>
> Addresses-Coverity: ("Resource leak")
> Fixes: 88d125026753 ("mtd: devices: add support for microchip 48l640 EERAM")
> Signed-off-by: Colin Ian King <[email protected]>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.

Miquel

2021-07-19 03:47:52

by Heiko Schocher

Subject: Re: [PATCH] mtd: devices: mchp48l640: Fix memory leak on cmd

Hello Colin,

On 12.07.21 16:52, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The allocation for cmd is not being kfree'd on the return leading to
> a memory leak. Fix this by kfree'ing it.
>
> Addresses-Coverity: ("Resource leak")
> Fixes: 88d125026753 ("mtd: devices: add support for microchip 48l640 EERAM")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/mtd/devices/mchp48l640.c | 1 +
> 1 file changed, 1 insertion(+)

Good catch, thanks!

Reviewed-by: Heiko Schocher <[email protected]>

bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]