2021-07-15 17:01:24

by Colin King

Subject: [PATCH] speakup: use C99 syntax for array initializers

From: Colin Ian King <[email protected]>

The older obsolete array initializer syntax is currently being used
for some of the array elements. Fix this by using the preferred C99
array initializers syntax.

Fixes: 5b5140bf5182 ("speakup: Separate out translations for bright colors names")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/accessibility/speakup/i18n.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/accessibility/speakup/i18n.c b/drivers/accessibility/speakup/i18n.c
index bc7b47d1876f..d62079b1661f 100644
--- a/drivers/accessibility/speakup/i18n.c
+++ b/drivers/accessibility/speakup/i18n.c
@@ -90,13 +90,13 @@ static char *speakup_default_msgs[MSG_LAST_INDEX] = {
[MSG_COLOR_YELLOW] = "yellow",
[MSG_COLOR_WHITE] = "white",
[MSG_COLOR_GREY] = "grey",
- [MSG_COLOR_BRIGHTBLUE] "bright blue",
- [MSG_COLOR_BRIGHTGREEN] "bright green",
- [MSG_COLOR_BRIGHTCYAN] "bright cyan",
- [MSG_COLOR_BRIGHTRED] "bright red",
- [MSG_COLOR_BRIGHTMAGENTA] "bright magenta",
- [MSG_COLOR_BRIGHTYELLOW] "bright yellow",
- [MSG_COLOR_BRIGHTWHITE] "bright white",
+ [MSG_COLOR_BRIGHTBLUE] = "bright blue",
+ [MSG_COLOR_BRIGHTGREEN] = "bright green",
+ [MSG_COLOR_BRIGHTCYAN] = "bright cyan",
+ [MSG_COLOR_BRIGHTRED] = "bright red",
+ [MSG_COLOR_BRIGHTMAGENTA] = "bright magenta",
+ [MSG_COLOR_BRIGHTYELLOW] = "bright yellow",
+ [MSG_COLOR_BRIGHTWHITE] = "bright white",

/* Names of key states. */
[MSG_STATE_DOUBLE] = "double",
--
2.31.1

2021-07-16 08:37:46

by Samuel Thibault

Subject: Re: [PATCH] speakup: use C99 syntax for array initializers

Colin King, le jeu. 15 juil. 2021 17:31:22 +0100, a ecrit:
> From: Colin Ian King <[email protected]>
>
> The older obsolete array initializer syntax is currently being used
> for some of the array elements. Fix this by using the preferred C99
> array initializers syntax.
>
> Fixes: 5b5140bf5182 ("speakup: Separate out translations for bright colors names")
> Signed-off-by: Colin Ian King <[email protected]>

Reviewed-by: Samuel Thibault <[email protected]>

> ---
> drivers/accessibility/speakup/i18n.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/accessibility/speakup/i18n.c b/drivers/accessibility/speakup/i18n.c
> index bc7b47d1876f..d62079b1661f 100644
> --- a/drivers/accessibility/speakup/i18n.c
> +++ b/drivers/accessibility/speakup/i18n.c
> @@ -90,13 +90,13 @@ static char *speakup_default_msgs[MSG_LAST_INDEX] = {
> [MSG_COLOR_YELLOW] = "yellow",
> [MSG_COLOR_WHITE] = "white",
> [MSG_COLOR_GREY] = "grey",
> - [MSG_COLOR_BRIGHTBLUE] "bright blue",
> - [MSG_COLOR_BRIGHTGREEN] "bright green",
> - [MSG_COLOR_BRIGHTCYAN] "bright cyan",
> - [MSG_COLOR_BRIGHTRED] "bright red",
> - [MSG_COLOR_BRIGHTMAGENTA] "bright magenta",
> - [MSG_COLOR_BRIGHTYELLOW] "bright yellow",
> - [MSG_COLOR_BRIGHTWHITE] "bright white",
> + [MSG_COLOR_BRIGHTBLUE] = "bright blue",
> + [MSG_COLOR_BRIGHTGREEN] = "bright green",
> + [MSG_COLOR_BRIGHTCYAN] = "bright cyan",
> + [MSG_COLOR_BRIGHTRED] = "bright red",
> + [MSG_COLOR_BRIGHTMAGENTA] = "bright magenta",
> + [MSG_COLOR_BRIGHTYELLOW] = "bright yellow",
> + [MSG_COLOR_BRIGHTWHITE] = "bright white",
>
> /* Names of key states. */
> [MSG_STATE_DOUBLE] = "double",
> --
> 2.31.1
>