2021-07-13 06:02:40

by Quan Nguyen

[permalink] [raw]
Subject: [PATCH v5 1/4] dt-bindings: mfd: Add bindings for Ampere Altra SMPro MFD driver

Adds device tree bindings for SMPro MFD driver found on the Mt.Jade
hardware reference platform with Ampere's Altra Processor family.

The SMpro co-processor on Ampere Altra processor family is to monitor
and report various data included hwmon-related info, RAS errors, and
other miscellaneous information.

Signed-off-by: Quan Nguyen <[email protected]>
---
Changes in v5:
+ Dropped ../bindings/hwmon/ampere,ac01-hwmon.yaml file [Quan]
+ Removed patternProperties section and child DT nodes in example
section [Quan]
+ Revised commit message [Quan]

Changes in v4:
+ Revised the commit message to clarify how the specific info will
be handled commented by Rob.

Changes in v3:
+ Supported list of compatible string [Rob]
+ Introduced reg property in DT to specify reg offset [Rob]
+ Updated description and other minor changes in yaml file [Rob]

Changes in v2:
+ Changed "ampere,ac01-smpro" to "ampere,smpro" [Quan]

.../devicetree/bindings/mfd/ampere,smpro.yaml | 52 +++++++++++++++++++
1 file changed, 52 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/ampere,smpro.yaml

diff --git a/Documentation/devicetree/bindings/mfd/ampere,smpro.yaml b/Documentation/devicetree/bindings/mfd/ampere,smpro.yaml
new file mode 100644
index 000000000000..8b48747e5de3
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/ampere,smpro.yaml
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/ampere,smpro.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Ampere Altra SMPro firmware driver
+
+maintainers:
+ - Quan Nguyen <[email protected]>
+
+description: |
+ Ampere Altra SMPro firmware may contain different blocks like hardware
+ monitoring, error monitoring and other miscellaneous features.
+
+properties:
+ compatible:
+ enum:
+ - ampere,smpro
+
+ reg:
+ description:
+ I2C device address.
+ maxItems: 1
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+required:
+ - "#address-cells"
+ - "#size-cells"
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ smpro@4f {
+ compatible = "ampere,smpro";
+ reg = <0x4f>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+ };
--
2.28.0


2021-07-16 17:37:06

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v5 1/4] dt-bindings: mfd: Add bindings for Ampere Altra SMPro MFD driver

On Tue, 13 Jul 2021 13:00:28 +0700, Quan Nguyen wrote:
> Adds device tree bindings for SMPro MFD driver found on the Mt.Jade
> hardware reference platform with Ampere's Altra Processor family.
>
> The SMpro co-processor on Ampere Altra processor family is to monitor
> and report various data included hwmon-related info, RAS errors, and
> other miscellaneous information.
>
> Signed-off-by: Quan Nguyen <[email protected]>
> ---
> Changes in v5:
> + Dropped ../bindings/hwmon/ampere,ac01-hwmon.yaml file [Quan]
> + Removed patternProperties section and child DT nodes in example
> section [Quan]
> + Revised commit message [Quan]
>
> Changes in v4:
> + Revised the commit message to clarify how the specific info will
> be handled commented by Rob.
>
> Changes in v3:
> + Supported list of compatible string [Rob]
> + Introduced reg property in DT to specify reg offset [Rob]
> + Updated description and other minor changes in yaml file [Rob]
>
> Changes in v2:
> + Changed "ampere,ac01-smpro" to "ampere,smpro" [Quan]
>
> .../devicetree/bindings/mfd/ampere,smpro.yaml | 52 +++++++++++++++++++
> 1 file changed, 52 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/ampere,smpro.yaml
>

Reviewed-by: Rob Herring <[email protected]>

2021-07-17 12:55:47

by Quan Nguyen

[permalink] [raw]
Subject: Re: [PATCH v5 1/4] dt-bindings: mfd: Add bindings for Ampere Altra SMPro MFD driver

On 17/07/2021 00:34, Rob Herring wrote:
> On Tue, 13 Jul 2021 13:00:28 +0700, Quan Nguyen wrote:
>> Adds device tree bindings for SMPro MFD driver found on the Mt.Jade
>> hardware reference platform with Ampere's Altra Processor family.
>>
>> The SMpro co-processor on Ampere Altra processor family is to monitor
>> and report various data included hwmon-related info, RAS errors, and
>> other miscellaneous information.
>>
>> Signed-off-by: Quan Nguyen <[email protected]>
>> ---
>> Changes in v5:
>> + Dropped ../bindings/hwmon/ampere,ac01-hwmon.yaml file [Quan]
>> + Removed patternProperties section and child DT nodes in example
>> section [Quan]
>> + Revised commit message [Quan]
>>
>> Changes in v4:
>> + Revised the commit message to clarify how the specific info will
>> be handled commented by Rob.
>>
>> Changes in v3:
>> + Supported list of compatible string [Rob]
>> + Introduced reg property in DT to specify reg offset [Rob]
>> + Updated description and other minor changes in yaml file [Rob]
>>
>> Changes in v2:
>> + Changed "ampere,ac01-smpro" to "ampere,smpro" [Quan]
>>
>> .../devicetree/bindings/mfd/ampere,smpro.yaml | 52 +++++++++++++++++++
>> 1 file changed, 52 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mfd/ampere,smpro.yaml
>>
>
> Reviewed-by: Rob Herring <[email protected]>
>

Thanks Rob for the review.
- Quan