Add device tree bindings for PLL of Toshiba Visconti TMPV770x SoC series.
Signed-off-by: Nobuhiro Iwamatsu <[email protected]>
---
.../clock/toshiba,tmpv770x-pipllct.yaml | 49 +++++++++++++++++++
1 file changed, 49 insertions(+)
create mode 100644 Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml
diff --git a/Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml b/Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml
new file mode 100644
index 000000000000..e88c9e4c4982
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/toshiba,tmpv770x-pipllct.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Toshiba Visconti5 TMPV770X PLL Controller Device Tree Bindings
+
+maintainers:
+ - Nobuhiro Iwamatsu <[email protected]>
+
+description:
+ Toshia Visconti5 PLL controller which supports the PLLs on TMPV770X.
+
+properties:
+ compatible:
+ const: toshiba,tmpv7708-pipllct
+
+ reg:
+ maxItems: 1
+
+ '#clock-cells':
+ const: 1
+
+ osc2-clk-frequency:
+ description: Frequency of the OSC2 oscillator.
+
+required:
+ - compatible
+ - reg
+ - "#clock-cells"
+ - osc2-clk-frequency
+
+additionalProperties: false
+
+examples:
+ - |
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ pipllct: pipllct@24220000 {
+ compatible = "toshiba,tmpv7708-pipllct";
+ reg = <0 0x24220000 0 0x820>;
+ #clock-cells = <1>;
+ osc2-clk-frequency = <20000000>;
+ };
+ };
+...
--
2.32.0
On Thu, Jun 24, 2021 at 12:43:35PM +0900, Nobuhiro Iwamatsu wrote:
> Add device tree bindings for PLL of Toshiba Visconti TMPV770x SoC series.
>
> Signed-off-by: Nobuhiro Iwamatsu <[email protected]>
> ---
> .../clock/toshiba,tmpv770x-pipllct.yaml | 49 +++++++++++++++++++
> 1 file changed, 49 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml b/Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml
> new file mode 100644
> index 000000000000..e88c9e4c4982
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/toshiba,tmpv770x-pipllct.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Toshiba Visconti5 TMPV770X PLL Controller Device Tree Bindings
> +
> +maintainers:
> + - Nobuhiro Iwamatsu <[email protected]>
> +
> +description:
> + Toshia Visconti5 PLL controller which supports the PLLs on TMPV770X.
> +
> +properties:
> + compatible:
> + const: toshiba,tmpv7708-pipllct
> +
> + reg:
> + maxItems: 1
> +
> + '#clock-cells':
> + const: 1
> +
> + osc2-clk-frequency:
> + description: Frequency of the OSC2 oscillator.
This is an external input? This should be a fixed-clock and this node
needs 'clocks' to connect it.
> +
> +required:
> + - compatible
> + - reg
> + - "#clock-cells"
> + - osc2-clk-frequency
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + pipllct: pipllct@24220000 {
clock-controller@...
> + compatible = "toshiba,tmpv7708-pipllct";
> + reg = <0 0x24220000 0 0x820>;
> + #clock-cells = <1>;
> + osc2-clk-frequency = <20000000>;
> + };
> + };
> +...
> --
> 2.32.0
>
>
Hi,
Thanks for your review.
On Wed, Jul 14, 2021 at 01:23:39PM -0600, Rob Herring wrote:
> On Thu, Jun 24, 2021 at 12:43:35PM +0900, Nobuhiro Iwamatsu wrote:
> > Add device tree bindings for PLL of Toshiba Visconti TMPV770x SoC series.
> >
> > Signed-off-by: Nobuhiro Iwamatsu <[email protected]>
> > ---
> > .../clock/toshiba,tmpv770x-pipllct.yaml | 49 +++++++++++++++++++
> > 1 file changed, 49 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml b/Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml
> > new file mode 100644
> > index 000000000000..e88c9e4c4982
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml
> > @@ -0,0 +1,49 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/toshiba,tmpv770x-pipllct.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Toshiba Visconti5 TMPV770X PLL Controller Device Tree Bindings
> > +
> > +maintainers:
> > + - Nobuhiro Iwamatsu <[email protected]>
> > +
> > +description:
> > + Toshia Visconti5 PLL controller which supports the PLLs on TMPV770X.
> > +
> > +properties:
> > + compatible:
> > + const: toshiba,tmpv7708-pipllct
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + '#clock-cells':
> > + const: 1
> > +
> > + osc2-clk-frequency:
> > + description: Frequency of the OSC2 oscillator.
>
> This is an external input? This should be a fixed-clock and this node
> needs 'clocks' to connect it.
OK, I will rewrite using fixed-clock.
>
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - "#clock-cells"
> > + - osc2-clk-frequency
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + soc {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > +
> > + pipllct: pipllct@24220000 {
>
> clock-controller@...
I will fix.
>
> > + compatible = "toshiba,tmpv7708-pipllct";
> > + reg = <0 0x24220000 0 0x820>;
> > + #clock-cells = <1>;
> > + osc2-clk-frequency = <20000000>;
> > + };
> > + };
> > +...
> > --
> > 2.32.0
> >
> >
>
Best regards,
Nobuhiro