2021-08-02 18:00:24

by Nathan Chancellor

Subject: [PATCH] dmaengine: idxd: Remove unused status variable in irq_process_work_list()

status is no longer used within this block:

drivers/dma/idxd/irq.c:255:6: warning: unused variable 'status'
[-Wunused-variable]
u8 status = desc->completion->status & DSA_COMP_STATUS_MASK;
^
1 warning generated.

Fixes: b60bb6e2bfc1 ("dmaengine: idxd: fix abort status check")
Signed-off-by: Nathan Chancellor <[email protected]>
---
drivers/dma/idxd/irq.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c
index 65dc7bbb0a13..91e46ca3a0ad 100644
--- a/drivers/dma/idxd/irq.c
+++ b/drivers/dma/idxd/irq.c
@@ -252,8 +252,6 @@ static int irq_process_work_list(struct idxd_irq_entry *irq_entry,
spin_unlock_irqrestore(&irq_entry->list_lock, flags);

list_for_each_entry(desc, &flist, list) {
- u8 status = desc->completion->status & DSA_COMP_STATUS_MASK;
-
/*
* Check against the original status as ABORT is software defined
* and 0xff, which DSA_COMP_STATUS_MASK can mask out.

base-commit: e9c5b0b53ccca81dd0a35c62309e243a57c7959d
--
2.32.0.264.g75ae10bc75

2021-08-02 18:04:27

by Dave Jiang

Subject: Re: [PATCH] dmaengine: idxd: Remove unused status variable in irq_process_work_list()

On 8/2/2021 10:58 AM, Nathan Chancellor wrote:
> status is no longer used within this block:
>
> drivers/dma/idxd/irq.c:255:6: warning: unused variable 'status'
> [-Wunused-variable]
> u8 status = desc->completion->status & DSA_COMP_STATUS_MASK;
> ^
> 1 warning generated.
>
> Fixes: b60bb6e2bfc1 ("dmaengine: idxd: fix abort status check")
> Signed-off-by: Nathan Chancellor <[email protected]>

Acked-by: Dave Jiang <[email protected]>

Thanks.


> ---
> drivers/dma/idxd/irq.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c
> index 65dc7bbb0a13..91e46ca3a0ad 100644
> --- a/drivers/dma/idxd/irq.c
> +++ b/drivers/dma/idxd/irq.c
> @@ -252,8 +252,6 @@ static int irq_process_work_list(struct idxd_irq_entry *irq_entry,
> spin_unlock_irqrestore(&irq_entry->list_lock, flags);
>
> list_for_each_entry(desc, &flist, list) {
> - u8 status = desc->completion->status & DSA_COMP_STATUS_MASK;
> -
> /*
> * Check against the original status as ABORT is software defined
> * and 0xff, which DSA_COMP_STATUS_MASK can mask out.
>
> base-commit: e9c5b0b53ccca81dd0a35c62309e243a57c7959d

2021-08-06 18:50:18

by Vinod Koul

Subject: Re: [PATCH] dmaengine: idxd: Remove unused status variable in irq_process_work_list()

On 02-08-21, 10:58, Nathan Chancellor wrote:
> status is no longer used within this block:
>
> drivers/dma/idxd/irq.c:255:6: warning: unused variable 'status'
> [-Wunused-variable]
> u8 status = desc->completion->status & DSA_COMP_STATUS_MASK;
> ^
> 1 warning generated.

Applied, thanks

--
~Vinod