2021-08-06 16:51:47

by Colin King

Subject: [PATCH] xen-blkfront: Remove redundant assignment to variable err

From: Colin Ian King <[email protected]>

The variable err is being assigned a value that is never read, the
assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/block/xen-blkfront.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index d83fee21f6c5..715bfa8aca7f 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -1092,7 +1092,6 @@ static int xlvbd_alloc_gendisk(blkif_sector_t capacity,
err = xlbd_reserve_minors(minor, nr_minors);
if (err)
return err;
- err = -ENODEV;

memset(&info->tag_set, 0, sizeof(info->tag_set));
info->tag_set.ops = &blkfront_mq_ops;
--
2.31.1

2021-08-10 05:25:11

by Boris Ostrovsky

Subject: Re: [PATCH] xen-blkfront: Remove redundant assignment to variable err

On 8/6/21 7:06 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The variable err is being assigned a value that is never read, the
> assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>


Reviewed-by: Boris Ostrovsky <[email protected]>

2021-08-10 05:52:04

by Jens Axboe

Subject: Re: [PATCH] xen-blkfront: Remove redundant assignment to variable err

On 8/6/21 5:06 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The variable err is being assigned a value that is never read, the
> assignment is redundant and can be removed.

Added for 5.15, thanks.

--
Jens Axboe