2021-08-08 06:25:10

by Wei Yongjun

Subject: [PATCH -next] erofs: make symbol 'erofs_iomap_ops' static

The sparse tool complains as follows:

fs/erofs/data.c:150:24: warning:
symbol 'erofs_iomap_ops' was not declared. Should it be static?

This symbol is not used outside of data.c, so marks it static.

Fixes: 3e9ce908c114 ("erofs: iomap support for non-tailpacking DIO")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Wei Yongjun <[email protected]>
---
fs/erofs/data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/erofs/data.c b/fs/erofs/data.c
index 4ea10b31790c..b2a22aabc9bc 100644
--- a/fs/erofs/data.c
+++ b/fs/erofs/data.c
@@ -147,7 +147,7 @@ static int erofs_iomap_end(struct inode *inode, loff_t pos, loff_t length,
return written;
}

-const struct iomap_ops erofs_iomap_ops = {
+static const struct iomap_ops erofs_iomap_ops = {
.iomap_begin = erofs_iomap_begin,
.iomap_end = erofs_iomap_end,
};

2021-08-08 13:27:03

by Gao Xiang

Subject: Re: [PATCH -next] erofs: make symbol 'erofs_iomap_ops' static

On Sun, Aug 08, 2021 at 06:33:43AM +0000, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> fs/erofs/data.c:150:24: warning:
> symbol 'erofs_iomap_ops' was not declared. Should it be static?
>
> This symbol is not used outside of data.c, so marks it static.
>
> Fixes: 3e9ce908c114 ("erofs: iomap support for non-tailpacking DIO")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Wei Yongjun <[email protected]>

Thanks,
Reviewed-by: Gao Xiang <[email protected]>

Thanks,
Gao Xiang

2021-08-08 23:59:50

by Chao Yu

Subject: Re: [PATCH -next] erofs: make symbol 'erofs_iomap_ops' static

On 2021/8/8 21:19, Gao Xiang wrote:
> On Sun, Aug 08, 2021 at 06:33:43AM +0000, Wei Yongjun wrote:
>> The sparse tool complains as follows:
>>
>> fs/erofs/data.c:150:24: warning:
>> symbol 'erofs_iomap_ops' was not declared. Should it be static?
>>
>> This symbol is not used outside of data.c, so marks it static.

Thanks for the patch, I guess it will be better to fix in original patch
if you don't mind.

Thanks,

>>
>> Fixes: 3e9ce908c114 ("erofs: iomap support for non-tailpacking DIO")
>> Reported-by: Hulk Robot <[email protected]>
>> Signed-off-by: Wei Yongjun <[email protected]>
>
> Thanks,
> Reviewed-by: Gao Xiang <[email protected]>
>
> Thanks,
> Gao Xiang
>

2021-08-09 02:58:05

by Wei Yongjun

Subject: Re: [PATCH -next] erofs: make symbol 'erofs_iomap_ops' static

在 2021/8/9 7:56, Chao Yu 写道:
> On 2021/8/8 21:19, Gao Xiang wrote:
>> On Sun, Aug 08, 2021 at 06:33:43AM +0000, Wei Yongjun wrote:
>>> The sparse tool complains as follows:
>>>
>>> fs/erofs/data.c:150:24: warning:
>>>   symbol 'erofs_iomap_ops' was not declared. Should it be static?
>>>
>>> This symbol is not used outside of data.c, so marks it static.
>
> Thanks for the patch, I guess it will be better to fix in original patch
> if you don't mind.


Yes, better to fix in original patch.

Regards.

2021-08-09 03:15:44

by Gao Xiang

Subject: Re: [PATCH -next] erofs: make symbol 'erofs_iomap_ops' static

On Mon, Aug 09, 2021 at 10:49:31AM +0800, weiyongjun (A) wrote:
>
> 在 2021/8/9 7:56, Chao Yu 写道:
> > On 2021/8/8 21:19, Gao Xiang wrote:
> > > On Sun, Aug 08, 2021 at 06:33:43AM +0000, Wei Yongjun wrote:
> > > > The sparse tool complains as follows:
> > > >
> > > > fs/erofs/data.c:150:24: warning:
> > > >   symbol 'erofs_iomap_ops' was not declared. Should it be static?
> > > >
> > > > This symbol is not used outside of data.c, so marks it static.
> >
> > Thanks for the patch, I guess it will be better to fix in original patch
> > if you don't mind.
>
>
> Yes, better to fix in original patch.

Ok, I'll merge this into the original patch this tomorrow.
(Anyway, thanks for the report!)

Thanks,
Gao Xiang

>
> Regards.