2021-08-16 08:58:06

by Dinghao Liu

[permalink] [raw]
Subject: [PATCH] RDMA/bnxt_re: Remove redundant unlock in bnxt_re_dev_init

Commit c2b777a95923 removes all rtnl_lock() and rtnl_unlock()
in function bnxt_re_dev_init(), but forgets to remove a rtnl_unlock()
in the error handling path of bnxt_re_register_netdev(), which may
cause a deadlock. This bug is suggested by a static analysis tool,
please advise.

Fixes: c2b777a95923 ("RDMA/bnxt_re: Refactor device add/remove functionalities")
Signed-off-by: Dinghao Liu <[email protected]>
---
drivers/infiniband/hw/bnxt_re/main.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
index a8688a92c760..4678bd6ec7d6 100644
--- a/drivers/infiniband/hw/bnxt_re/main.c
+++ b/drivers/infiniband/hw/bnxt_re/main.c
@@ -1397,7 +1397,6 @@ static int bnxt_re_dev_init(struct bnxt_re_dev *rdev, u8 wqe_mode)
memset(&rattr, 0, sizeof(rattr));
rc = bnxt_re_register_netdev(rdev);
if (rc) {
- rtnl_unlock();
ibdev_err(&rdev->ibdev,
"Failed to register with netedev: %#x\n", rc);
return -EINVAL;
--
2.17.1


2021-08-16 09:18:46

by Selvin Xavier

[permalink] [raw]
Subject: Re: [PATCH] RDMA/bnxt_re: Remove redundant unlock in bnxt_re_dev_init

On Mon, Aug 16, 2021 at 2:26 PM Dinghao Liu <[email protected]> wrote:
>
> Commit c2b777a95923 removes all rtnl_lock() and rtnl_unlock()
> in function bnxt_re_dev_init(), but forgets to remove a rtnl_unlock()
> in the error handling path of bnxt_re_register_netdev(), which may
> cause a deadlock. This bug is suggested by a static analysis tool,
> please advise.
>
> Fixes: c2b777a95923 ("RDMA/bnxt_re: Refactor device add/remove functionalities")
> Signed-off-by: Dinghao Liu <[email protected]>

Acked-by: Selvin Xavier <[email protected]>

Attachments:
smime.p7s (4.12 kB)
S/MIME Cryptographic Signature

2021-08-19 18:04:30

by Jason Gunthorpe

[permalink] [raw]
Subject: Re: [PATCH] RDMA/bnxt_re: Remove redundant unlock in bnxt_re_dev_init

On Mon, Aug 16, 2021 at 04:55:31PM +0800, Dinghao Liu wrote:
> Commit c2b777a95923 removes all rtnl_lock() and rtnl_unlock()
> in function bnxt_re_dev_init(), but forgets to remove a rtnl_unlock()
> in the error handling path of bnxt_re_register_netdev(), which may
> cause a deadlock. This bug is suggested by a static analysis tool,
> please advise.
>
> Fixes: c2b777a95923 ("RDMA/bnxt_re: Refactor device add/remove functionalities")
> Signed-off-by: Dinghao Liu <[email protected]>
> Acked-by: Selvin Xavier <[email protected]>
> ---
> drivers/infiniband/hw/bnxt_re/main.c | 1 -
> 1 file changed, 1 deletion(-)

Applied to for-rc, thanks

Jason