2021-08-22 00:00:46

by Bryan Brattlof

Subject: [PATCH 3/6] staging: rtl8723bs: remove sdio_read_mem()

The sdio_read_mem() function is unused. We can remove it.

Signed-off-by: Bryan Brattlof <[email protected]>
---
drivers/staging/rtl8723bs/hal/sdio_ops.c | 11 -----------
drivers/staging/rtl8723bs/include/rtw_io.h | 2 --
2 files changed, 13 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
index 6bd662928ab6..019ace4b8564 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
@@ -299,16 +299,6 @@ static s32 sdio_write32(struct intf_hdl *intfhdl, u32 addr, u32 val)
return err;
}

-static void sdio_read_mem(
- struct intf_hdl *intfhdl,
- u32 addr,
- u32 cnt,
- u8 *rmem
-)
-{
- sdio_readN(intfhdl, addr, cnt, rmem);
-}
-
/*
* Description:
*Read from RX FIFO
@@ -410,7 +400,6 @@ void sdio_set_intf_ops(struct adapter *adapter, struct _io_ops *ops)
ops->_read8 = &sdio_read8;
ops->_read16 = &sdio_read16;
ops->_read32 = &sdio_read32;
- ops->_read_mem = &sdio_read_mem;
ops->_read_port = &sdio_read_port;

ops->_write8 = &sdio_write8;
diff --git a/drivers/staging/rtl8723bs/include/rtw_io.h b/drivers/staging/rtl8723bs/include/rtw_io.h
index 0753e20cfaa2..43102f65bddd 100644
--- a/drivers/staging/rtl8723bs/include/rtw_io.h
+++ b/drivers/staging/rtl8723bs/include/rtw_io.h
@@ -89,8 +89,6 @@ struct _io_ops {
int (*_write16_async)(struct intf_hdl *pintfhdl, u32 addr, u16 val);
int (*_write32_async)(struct intf_hdl *pintfhdl, u32 addr, u32 val);

- void (*_read_mem)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pmem);
-
void (*_sync_irp_protocol_rw)(struct io_queue *pio_q);

u32 (*_read_interrupt)(struct intf_hdl *pintfhdl, u32 addr);
--
2.30.2

2021-08-22 06:26:43

by Fabio M. De Francesco

Subject: Re: [PATCH 3/6] staging: rtl8723bs: remove sdio_read_mem()

On Sunday, August 22, 2021 1:55:29 AM CEST Bryan Brattlof wrote:
> The sdio_read_mem() function is unused. We can remove it.
>
> Signed-off-by: Bryan Brattlof <[email protected]>
> ---
> drivers/staging/rtl8723bs/hal/sdio_ops.c | 11 -----------
> drivers/staging/rtl8723bs/include/rtw_io.h | 2 --
> 2 files changed, 13 deletions(-)

This change adds a build warning, which is not allowed.

Please merge this, and the 4/6 patch into a single change, so that it
all is removed together, causing no build warnings at any point in time.

thanks,

Fabio

2021-08-22 13:55:48

by Bryan Brattlof

Subject: Re: [PATCH 3/6] staging: rtl8723bs: remove sdio_read_mem()

On 22.08.2021 08:25, Fabio M. De Francesco wrote:
> On Sunday, August 22, 2021 1:55:29 AM CEST Bryan Brattlof wrote:
> > The sdio_read_mem() function is unused. We can remove it.
> >
> > Signed-off-by: Bryan Brattlof <[email protected]>
> > ---
> > drivers/staging/rtl8723bs/hal/sdio_ops.c | 11 -----------
> > drivers/staging/rtl8723bs/include/rtw_io.h | 2 --
> > 2 files changed, 13 deletions(-)
>
> This change adds a build warning, which is not allowed.
>
> Please merge this, and the 4/6 patch into a single change, so that it
> all is removed together, causing no build warnings at any point in time.
>

Will do.

Thanks for the review, Fabio!
~Bryan

>
> thanks,
>
> Fabio
>
>
>