2021-08-22 20:47:10

by Bryan Brattlof

[permalink] [raw]
Subject: [PATCH v2 0/5] staging: rtl8723bs: remove unused functions

Changes in v2:
- Remove build warnings I introduced in the previous version.

***

There is a lot of un-used code and un-needed abstractions leftover
in this driver from when (I assume) it could be compiled on more than
one kernel.

This series removes dead code and is one small step toward
refactoring how this driver interacts with the SDIO subsystem.

Bryan Brattlof (5):
staging: rtl8723bs: remove sdio_write_mem()
staging: rtl8723bs: remove sdio_writeN()
staging: rtl8723bs: remove sdio_read_mem() and sdio_readN()
staging: rtl8723bs: remove unused definitions from rtw_io.h
staging: rtl8723bs: remove _read_port from _io_ops structure

drivers/staging/rtl8723bs/hal/sdio_ops.c | 116 ---------------------
drivers/staging/rtl8723bs/include/rtw_io.h | 96 -----------------
2 files changed, 212 deletions(-)

--
2.30.2



2021-08-26 10:11:33

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v2 0/5] staging: rtl8723bs: remove unused functions

On Sun, Aug 22, 2021 at 08:42:58PM +0000, Bryan Brattlof wrote:
> Changes in v2:
> - Remove build warnings I introduced in the previous version.
>
> ***
>
> There is a lot of un-used code and un-needed abstractions leftover
> in this driver from when (I assume) it could be compiled on more than
> one kernel.
>
> This series removes dead code and is one small step toward
> refactoring how this driver interacts with the SDIO subsystem.
>

Better, but these are still not threaded properly (some were, patches 1
and 2, but not the rest.)

Please fix up and resend a v3.

thanks,

greg k-h