2021-08-25 06:27:52

by Cai,Huoqing

[permalink] [raw]
Subject: [PATCH] tpm: tis: Kconfig: Add helper dependency on COMPILE_TEST

it's helpful for complie test in other platform(e.g.X86)

Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/char/tpm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index d6ba644f6b00..4a5516406c22 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -76,7 +76,7 @@ config TCG_TIS_SPI_CR50

config TCG_TIS_SYNQUACER
tristate "TPM Interface Specification 1.2 Interface / TPM 2.0 FIFO Interface (MMIO - SynQuacer)"
- depends on ARCH_SYNQUACER
+ depends on ARCH_SYNQUACER || COMPILE_TEST
select TCG_TIS_CORE
help
If you have a TPM security chip that is compliant with the
--
2.25.1


2021-08-25 22:23:27

by Jarkko Sakkinen

[permalink] [raw]
Subject: Re: [PATCH] tpm: tis: Kconfig: Add helper dependency on COMPILE_TEST

On Wed, 2021-08-25 at 14:26 +0800, Cai Huoqing wrote:
> it's helpful for complie test in other platform(e.g.X86)

You need to write a proper long description, starting from that
sentences start with capital letter and end with a period.

What is "it"?


> Signed-off-by: Cai Huoqing <[email protected]>
> ---
> drivers/char/tpm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> index d6ba644f6b00..4a5516406c22 100644
> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -76,7 +76,7 @@ config TCG_TIS_SPI_CR50
>
> config TCG_TIS_SYNQUACER
> tristate "TPM Interface Specification 1.2 Interface / TPM 2.0 FIFO Interface (MMIO - SynQuacer)"
> - depends on ARCH_SYNQUACER
> + depends on ARCH_SYNQUACER || COMPILE_TEST
> select TCG_TIS_CORE
> help
> If you have a TPM security chip that is compliant with the

/Jarkko