2021-08-25 13:53:37

by Prarit Bhargava

[permalink] [raw]
Subject: [PATCH] mfd: intel_pmt: Only compile on x86

The intel_pmt driver shows up as a compile option for all arches but is
32-bit and 64-bit x86 specific.

Add a CONFIG dependency on X86 for intel_pmt.

Signed-off-by: Prarit Bhargava <[email protected]>
Cc: Lee Jones <[email protected]>
Cc: David E. Box <[email protected]>
Cc: Hans de Goede <[email protected]>
---
drivers/mfd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 6a3fd2d75f96..0f12b00955b4 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -676,7 +676,7 @@ config MFD_INTEL_PMC_BXT

config MFD_INTEL_PMT
tristate "Intel Platform Monitoring Technology (PMT) support"
- depends on PCI
+ depends on X86 && PCI
select MFD_CORE
help
The Intel Platform Monitoring Technology (PMT) is an interface that
--
2.31.1


2021-08-26 13:21:54

by Hans de Goede

[permalink] [raw]
Subject: Re: [PATCH] mfd: intel_pmt: Only compile on x86

Hi,

On 8/25/21 2:57 PM, Prarit Bhargava wrote:
> The intel_pmt driver shows up as a compile option for all arches but is
> 32-bit and 64-bit x86 specific.
>
> Add a CONFIG dependency on X86 for intel_pmt.
>
> Signed-off-by: Prarit Bhargava <[email protected]>
> Cc: Lee Jones <[email protected]>
> Cc: David E. Box <[email protected]>
> Cc: Hans de Goede <[email protected]>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <[email protected]>

Regards,

Hans



> ---
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 6a3fd2d75f96..0f12b00955b4 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -676,7 +676,7 @@ config MFD_INTEL_PMC_BXT
>
> config MFD_INTEL_PMT
> tristate "Intel Platform Monitoring Technology (PMT) support"
> - depends on PCI
> + depends on X86 && PCI
> select MFD_CORE
> help
> The Intel Platform Monitoring Technology (PMT) is an interface that
>

2021-08-26 18:59:12

by David E. Box

[permalink] [raw]
Subject: Re: [PATCH] mfd: intel_pmt: Only compile on x86

On Thu, 2021-08-26 at 15:19 +0200, Hans de Goede wrote:
> Hi,
>
> On 8/25/21 2:57 PM, Prarit Bhargava wrote:
> > The intel_pmt driver shows up as a compile option for all arches
> > but is
> > 32-bit and 64-bit x86 specific.
> >
> > Add a CONFIG dependency on X86 for intel_pmt.
> >
> > Signed-off-by: Prarit Bhargava <[email protected]>
> > Cc: Lee Jones <[email protected]>
> > Cc: David E. Box <[email protected]>
> > Cc: Hans de Goede <[email protected]>
>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <[email protected]>
>
> Regards,
>
> Hans

Okay by me.

Reviewed-by: David E. Box <[email protected]>

>
>
>
> > ---
> >  drivers/mfd/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 6a3fd2d75f96..0f12b00955b4 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -676,7 +676,7 @@ config MFD_INTEL_PMC_BXT
> >  
> >  config MFD_INTEL_PMT
> >         tristate "Intel Platform Monitoring Technology (PMT)
> > support"
> > -       depends on PCI
> > +       depends on X86 && PCI
> >         select MFD_CORE
> >         help
> >           The Intel Platform Monitoring Technology (PMT) is an
> > interface that
> >
>


2021-09-22 13:21:28

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH] mfd: intel_pmt: Only compile on x86

On Wed, 25 Aug 2021, Prarit Bhargava wrote:

> The intel_pmt driver shows up as a compile option for all arches but is
> 32-bit and 64-bit x86 specific.
>
> Add a CONFIG dependency on X86 for intel_pmt.
>
> Signed-off-by: Prarit Bhargava <[email protected]>
> Cc: Lee Jones <[email protected]>
> Cc: David E. Box <[email protected]>
> Cc: Hans de Goede <[email protected]>
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog