2021-08-30 17:32:39

by Jian Cai

Subject: [PATCH v2] coresight: syscfg: fix compiler warnings

This fixes warnings with -Wimplicit-function-declaration, e.g.

drivers/hwtracing/coresight/coresight-syscfg.c:455:15: error:
implicit declaration of function 'kzalloc' [-Werror,
-Wimplicit-function-declaration]
csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev),
GFP_KERNEL);

Fixes: 85e2414c518a ("coresight: syscfg: Initial coresight system configuration")
Reviewed-by: Guenter Roeck <[email protected]>
Signed-off-by: Jian Cai <[email protected]>
---

Changes v1 -> v2:
Format the commit message and add Fixes and Reviewed-by tag.

drivers/hwtracing/coresight/coresight-syscfg.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/hwtracing/coresight/coresight-syscfg.c b/drivers/hwtracing/coresight/coresight-syscfg.c
index fc0760f55c53..43054568430f 100644
--- a/drivers/hwtracing/coresight/coresight-syscfg.c
+++ b/drivers/hwtracing/coresight/coresight-syscfg.c
@@ -5,6 +5,7 @@
*/

#include <linux/platform_device.h>
+#include <linux/slab.h>

#include "coresight-config.h"
#include "coresight-etm-perf.h"
--
2.33.0.259.gc128427fd7-goog

2021-09-06 15:39:58

by Mathieu Poirier

Subject: Re: [PATCH v2] coresight: syscfg: fix compiler warnings

On Mon, Aug 30, 2021 at 10:28:19AM -0700, Jian Cai wrote:
> This fixes warnings with -Wimplicit-function-declaration, e.g.
>
> drivers/hwtracing/coresight/coresight-syscfg.c:455:15: error:
> implicit declaration of function 'kzalloc' [-Werror,
> -Wimplicit-function-declaration]
> csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev),
> GFP_KERNEL);
>
> Fixes: 85e2414c518a ("coresight: syscfg: Initial coresight system configuration")
> Reviewed-by: Guenter Roeck <[email protected]>
> Signed-off-by: Jian Cai <[email protected]>
> ---
>
> Changes v1 -> v2:
> Format the commit message and add Fixes and Reviewed-by tag.
>
> drivers/hwtracing/coresight/coresight-syscfg.c | 1 +
> 1 file changed, 1 insertion(+)
>

I have applied this patch to my local tree. I will push it to the coresight-next
branch when 5.15-rc1 is published next week.

Thanks,
Mathieu

> diff --git a/drivers/hwtracing/coresight/coresight-syscfg.c b/drivers/hwtracing/coresight/coresight-syscfg.c
> index fc0760f55c53..43054568430f 100644
> --- a/drivers/hwtracing/coresight/coresight-syscfg.c
> +++ b/drivers/hwtracing/coresight/coresight-syscfg.c
> @@ -5,6 +5,7 @@
> */
>
> #include <linux/platform_device.h>
> +#include <linux/slab.h>
>
> #include "coresight-config.h"
> #include "coresight-etm-perf.h"
> --
> 2.33.0.259.gc128427fd7-goog
>

2021-09-07 18:01:27

by Guenter Roeck

Subject: Re: [PATCH v2] coresight: syscfg: fix compiler warnings

On Tue, Sep 07, 2021 at 10:51:53AM -0700, Doug Anderson wrote:
> Hi,
>
> On Mon, Sep 6, 2021 at 8:06 AM Mathieu Poirier
> <[email protected]> wrote:
> >
> > On Mon, Aug 30, 2021 at 10:28:19AM -0700, Jian Cai wrote:
> > > This fixes warnings with -Wimplicit-function-declaration, e.g.
> > >
> > > drivers/hwtracing/coresight/coresight-syscfg.c:455:15: error:
> > > implicit declaration of function 'kzalloc' [-Werror,
> > > -Wimplicit-function-declaration]
> > > csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev),
> > > GFP_KERNEL);
> > >
> > > Fixes: 85e2414c518a ("coresight: syscfg: Initial coresight system configuration")
> > > Reviewed-by: Guenter Roeck <[email protected]>
> > > Signed-off-by: Jian Cai <[email protected]>
> > > ---
> > >
> > > Changes v1 -> v2:
> > > Format the commit message and add Fixes and Reviewed-by tag.
> > >
> > > drivers/hwtracing/coresight/coresight-syscfg.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> >
> > I have applied this patch to my local tree. I will push it to the coresight-next
> > branch when 5.15-rc1 is published next week.
>
> Out of curiosity, does the fact that it'll be in coresight-next mean
> that this will target v5.15 or v5.16? I usually think of "-next"
> branches as targeting one major version later, so I'd assume v5.16?
> ...but it would be nice if this warning could get fixed somewhere in
> v5.15.
>
Normally "when 5.15-rc1 is published" would imply v5.16.

Note that warnings are now reported as errors in mainline,
since -Werror is now enabled by default.

Guenter

2021-09-07 18:54:12

by Douglas Anderson

Subject: Re: [PATCH v2] coresight: syscfg: fix compiler warnings

Hi,

On Mon, Sep 6, 2021 at 8:06 AM Mathieu Poirier
<[email protected]> wrote:
>
> On Mon, Aug 30, 2021 at 10:28:19AM -0700, Jian Cai wrote:
> > This fixes warnings with -Wimplicit-function-declaration, e.g.
> >
> > drivers/hwtracing/coresight/coresight-syscfg.c:455:15: error:
> > implicit declaration of function 'kzalloc' [-Werror,
> > -Wimplicit-function-declaration]
> > csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev),
> > GFP_KERNEL);
> >
> > Fixes: 85e2414c518a ("coresight: syscfg: Initial coresight system configuration")
> > Reviewed-by: Guenter Roeck <[email protected]>
> > Signed-off-by: Jian Cai <[email protected]>
> > ---
> >
> > Changes v1 -> v2:
> > Format the commit message and add Fixes and Reviewed-by tag.
> >
> > drivers/hwtracing/coresight/coresight-syscfg.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
>
> I have applied this patch to my local tree. I will push it to the coresight-next
> branch when 5.15-rc1 is published next week.

Out of curiosity, does the fact that it'll be in coresight-next mean
that this will target v5.15 or v5.16? I usually think of "-next"
branches as targeting one major version later, so I'd assume v5.16?
...but it would be nice if this warning could get fixed somewhere in
v5.15.

Thanks and sorry if this was obvious and I just didn't know.

-Doug