2021-09-01 05:14:54

by Cai,Huoqing

Subject: [PATCH] media: am437x: Make use of the helper function devm_platform_ioremap_resource()

Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately

Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/media/platform/am437x/am437x-vpfe.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/media/platform/am437x/am437x-vpfe.c b/drivers/media/platform/am437x/am437x-vpfe.c
index 48bb0c93729c..2dfae9bc0bba 100644
--- a/drivers/media/platform/am437x/am437x-vpfe.c
+++ b/drivers/media/platform/am437x/am437x-vpfe.c
@@ -2393,7 +2393,6 @@ static int vpfe_probe(struct platform_device *pdev)
struct vpfe_config *vpfe_cfg;
struct vpfe_device *vpfe;
struct vpfe_ccdc *ccdc;
- struct resource *res;
int ret;

vpfe = devm_kzalloc(&pdev->dev, sizeof(*vpfe), GFP_KERNEL);
@@ -2411,8 +2410,7 @@ static int vpfe_probe(struct platform_device *pdev)
vpfe->cfg = vpfe_cfg;
ccdc = &vpfe->ccdc;

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- ccdc->ccdc_cfg.base_addr = devm_ioremap_resource(&pdev->dev, res);
+ ccdc->ccdc_cfg.base_addr = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(ccdc->ccdc_cfg.base_addr)) {
ret = PTR_ERR(ccdc->ccdc_cfg.base_addr);
goto probe_out_cleanup;
--
2.25.1

2021-09-05 21:54:44

by Lad, Prabhakar

Subject: Re: [PATCH] media: am437x: Make use of the helper function devm_platform_ioremap_resource()

Hi Cai,

Thank you for the patch.

On Wed, Sep 1, 2021 at 6:10 AM Cai Huoqing <[email protected]> wrote:
>
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <[email protected]>
> ---
> drivers/media/platform/am437x/am437x-vpfe.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Reviewed-by: Lad Prabhakar <[email protected]>

Cheers,
Prabhakar

> diff --git a/drivers/media/platform/am437x/am437x-vpfe.c b/drivers/media/platform/am437x/am437x-vpfe.c
> index 48bb0c93729c..2dfae9bc0bba 100644
> --- a/drivers/media/platform/am437x/am437x-vpfe.c
> +++ b/drivers/media/platform/am437x/am437x-vpfe.c
> @@ -2393,7 +2393,6 @@ static int vpfe_probe(struct platform_device *pdev)
> struct vpfe_config *vpfe_cfg;
> struct vpfe_device *vpfe;
> struct vpfe_ccdc *ccdc;
> - struct resource *res;
> int ret;
>
> vpfe = devm_kzalloc(&pdev->dev, sizeof(*vpfe), GFP_KERNEL);
> @@ -2411,8 +2410,7 @@ static int vpfe_probe(struct platform_device *pdev)
> vpfe->cfg = vpfe_cfg;
> ccdc = &vpfe->ccdc;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ccdc->ccdc_cfg.base_addr = devm_ioremap_resource(&pdev->dev, res);
> + ccdc->ccdc_cfg.base_addr = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(ccdc->ccdc_cfg.base_addr)) {
> ret = PTR_ERR(ccdc->ccdc_cfg.base_addr);
> goto probe_out_cleanup;
> --
> 2.25.1
>