2021-09-01 11:35:24

by Cai,Huoqing

[permalink] [raw]

Subject: [PATCH] drm/v3d: Make use of the helper function devm_platform_ioremap_resource_byname()

---

Use the devm_platform_ioremap_resource_byname() helper instead of
calling platform_get_resource_byname() and devm_ioremap_resource()
separately

Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/gpu/drm/v3d/v3d_drv.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c
index 9403c3b36aca..c1deab2cf38d 100644
--- a/drivers/gpu/drm/v3d/v3d_drv.c
+++ b/drivers/gpu/drm/v3d/v3d_drv.c
@@ -206,10 +206,7 @@ MODULE_DEVICE_TABLE(of, v3d_of_match);
static int
map_regs(struct v3d_dev *v3d, void __iomem **regs, const char *name)
{
- struct resource *res =
- platform_get_resource_byname(v3d_to_pdev(v3d), IORESOURCE_MEM, name);
-
- *regs = devm_ioremap_resource(v3d->drm.dev, res);
+ *regs = devm_platform_ioremap_resource_byname(v3d_to_pdev(v3d), name);
return PTR_ERR_OR_ZERO(*regs);
}

--
2.25.1

2021-09-20 10:04:27

by Melissa Wen

[permalink] [raw]

Subject: Re: [PATCH] drm/v3d: Make use of the helper function devm_platform_ioremap_resource_byname()

---

On 09/01, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource_byname() helper instead of
> calling platform_get_resource_byname() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <[email protected]>
> ---
> drivers/gpu/drm/v3d/v3d_drv.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c
> index 9403c3b36aca..c1deab2cf38d 100644
> --- a/drivers/gpu/drm/v3d/v3d_drv.c
> +++ b/drivers/gpu/drm/v3d/v3d_drv.c
> @@ -206,10 +206,7 @@ MODULE_DEVICE_TABLE(of, v3d_of_match);
> static int
> map_regs(struct v3d_dev *v3d, void __iomem **regs, const char *name)
> {
> - struct resource *res =
> - platform_get_resource_byname(v3d_to_pdev(v3d), IORESOURCE_MEM, name);
> -
> - *regs = devm_ioremap_resource(v3d->drm.dev, res);
> + *regs = devm_platform_ioremap_resource_byname(v3d_to_pdev(v3d), name);
> return PTR_ERR_OR_ZERO(*regs);
> }
lgtm.

Reviewed-by: Melissa Wen <[email protected]>
>
> --
> 2.25.1
>

---

Attachments:

(No filename) (1.04 kB)
signature.asc (849.00 B)
Download all attachments

2021-09-22 08:13:34

by Melissa Wen

[permalink] [raw]

Subject: Re: [PATCH] drm/v3d: Make use of the helper function devm_platform_ioremap_resource_byname()

---

On 09/20, Melissa Wen wrote:
> On 09/01, Cai Huoqing wrote:
> > Use the devm_platform_ioremap_resource_byname() helper instead of
> > calling platform_get_resource_byname() and devm_ioremap_resource()
> > separately
> >
> > Signed-off-by: Cai Huoqing <[email protected]>
> > ---
> > drivers/gpu/drm/v3d/v3d_drv.c | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c
> > index 9403c3b36aca..c1deab2cf38d 100644
> > --- a/drivers/gpu/drm/v3d/v3d_drv.c
> > +++ b/drivers/gpu/drm/v3d/v3d_drv.c
> > @@ -206,10 +206,7 @@ MODULE_DEVICE_TABLE(of, v3d_of_match);
> > static int
> > map_regs(struct v3d_dev *v3d, void __iomem **regs, const char *name)
> > {
> > - struct resource *res =
> > - platform_get_resource_byname(v3d_to_pdev(v3d), IORESOURCE_MEM, name);
> > -
> > - *regs = devm_ioremap_resource(v3d->drm.dev, res);
> > + *regs = devm_platform_ioremap_resource_byname(v3d_to_pdev(v3d), name);
> > return PTR_ERR_OR_ZERO(*regs);
> > }
> lgtm.
>
> Reviewed-by: Melissa Wen <[email protected]>

and applied to drm-misc-next.

Thanks,

Melissa
> >
> > --
> > 2.25.1
> >