2021-08-20 03:25:25

by CGEL

Subject: [PATCH linux-next] tee/optee/shm_pool: fix application of sizeof to pointer

From: jing yangyang <[email protected]>

sizeof when applied to a pointer typed expression gives the size of
the pointer.

./drivers/tee/optee/shm_pool.c:38:28-34: ERROR application of sizeof to pointer

This issue was detected with the help of Coccinelle.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: jing yangyang <[email protected]>
---
drivers/tee/optee/shm_pool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tee/optee/shm_pool.c b/drivers/tee/optee/shm_pool.c
index c41a9a5..d167039 100644
--- a/drivers/tee/optee/shm_pool.c
+++ b/drivers/tee/optee/shm_pool.c
@@ -35,7 +35,7 @@ static int pool_op_alloc(struct tee_shm_pool_mgr *poolm,
unsigned int nr_pages = 1 << order, i;
struct page **pages;

- pages = kcalloc(nr_pages, sizeof(pages), GFP_KERNEL);
+ pages = kcalloc(nr_pages, sizeof(*pages), GFP_KERNEL);
if (!pages) {
rc = -ENOMEM;
goto err;
--
1.8.3.1

2021-09-02 10:53:50

by Daniel Thompson

Subject: Re: [PATCH linux-next] tee/optee/shm_pool: fix application of sizeof to pointer

On Thu, Aug 19, 2021 at 08:21:27PM -0700, CGEL wrote:
> From: jing yangyang <[email protected]>
>
> sizeof when applied to a pointer typed expression gives the size of
> the pointer.
>
> ./drivers/tee/optee/shm_pool.c:38:28-34: ERROR application of sizeof to pointer
>
> This issue was detected with the help of Coccinelle.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: jing yangyang <[email protected]>

This should not affect code generation since both pages and *pages are
pointers but the change looks good to me.

Reviewed-by: Daniel Thompson <[email protected]>


> ---
> drivers/tee/optee/shm_pool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tee/optee/shm_pool.c b/drivers/tee/optee/shm_pool.c
> index c41a9a5..d167039 100644
> --- a/drivers/tee/optee/shm_pool.c
> +++ b/drivers/tee/optee/shm_pool.c
> @@ -35,7 +35,7 @@ static int pool_op_alloc(struct tee_shm_pool_mgr *poolm,
> unsigned int nr_pages = 1 << order, i;
> struct page **pages;
>
> - pages = kcalloc(nr_pages, sizeof(pages), GFP_KERNEL);
> + pages = kcalloc(nr_pages, sizeof(*pages), GFP_KERNEL);
> if (!pages) {
> rc = -ENOMEM;
> goto err;
> --
> 1.8.3.1

2021-09-13 09:24:42

by Jens Wiklander

Subject: Re: [PATCH linux-next] tee/optee/shm_pool: fix application of sizeof to pointer

On Thu, Sep 02, 2021 at 11:34:28AM +0100, Daniel Thompson wrote:
> On Thu, Aug 19, 2021 at 08:21:27PM -0700, CGEL wrote:
> > From: jing yangyang <[email protected]>
> >
> > sizeof when applied to a pointer typed expression gives the size of
> > the pointer.
> >
> > ./drivers/tee/optee/shm_pool.c:38:28-34: ERROR application of sizeof to pointer
> >
> > This issue was detected with the help of Coccinelle.
> >
> > Reported-by: Zeal Robot <[email protected]>
> > Signed-off-by: jing yangyang <[email protected]>
>
> This should not affect code generation since both pages and *pages are
> pointers but the change looks good to me.
>
> Reviewed-by: Daniel Thompson <[email protected]>

Thanks for reviewing, I agree with your analysis.
I'm picking this up as a bugfix for V5.15.

Cheers,
Jens