Previous commit 68233c583ab4 removes the qlcnic_rom_lock()
in qlcnic_pinit_from_rom(), but remains its corresponding
unlock function, which is odd. I'm not very sure whether the
lock is missing, or the unlock is redundant. This bug is
suggested by a static analysis tool, please advise.
Fixes: 68233c583ab4 ("qlcnic: updated reset sequence")
Signed-off-by: Dinghao Liu <[email protected]>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c
index 3d61a767a8a3..09f20c794754 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c
@@ -437,7 +437,6 @@ int qlcnic_pinit_from_rom(struct qlcnic_adapter *adapter)
QLCWR32(adapter, QLCNIC_CRB_PEG_NET_4 + 0x3c, 1);
msleep(20);
- qlcnic_rom_unlock(adapter);
/* big hammer don't reset CAM block on reset */
QLCWR32(adapter, QLCNIC_ROMUSB_GLB_SW_RESET, 0xfeffffff);
--
2.17.1
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 3 Sep 2021 15:35:43 +0800 you wrote:
> Previous commit 68233c583ab4 removes the qlcnic_rom_lock()
> in qlcnic_pinit_from_rom(), but remains its corresponding
> unlock function, which is odd. I'm not very sure whether the
> lock is missing, or the unlock is redundant. This bug is
> suggested by a static analysis tool, please advise.
>
> Fixes: 68233c583ab4 ("qlcnic: updated reset sequence")
> Signed-off-by: Dinghao Liu <[email protected]>
>
> [...]
Here is the summary with links:
- qlcnic: Remove redundant unlock in qlcnic_pinit_from_rom
https://git.kernel.org/netdev/net/c/9ddbc2a00d7f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html