2021-09-03 20:09:12

by Alakesh Haloi

Subject: [PATCH] media: staging: media: atomisp: fix return value

This fixes following error seen during module build
error: control reaches end of non-void function [-Werror=return-type]

Signed-off-by: Alakesh Haloi <[email protected]>
---
.../media/atomisp/pci/hive_isp_css_common/host/input_system.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
index 8e085dda0c18..5d088d6fb01f 100644
--- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
+++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
@@ -1646,6 +1646,7 @@ static input_system_err_t input_system_configure_channel_sensor(
default:
return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED;
}
+ return status;
}

// Test flags and set structure.
--
2.25.1

2021-09-06 07:34:51

by Dan Carpenter

Subject: Re: [PATCH] media: staging: media: atomisp: fix return value

On Fri, Sep 03, 2021 at 08:06:58PM +0000, Alakesh Haloi wrote:
> This fixes following error seen during module build
> error: control reaches end of non-void function [-Werror=return-type]
>
> Signed-off-by: Alakesh Haloi <[email protected]>
> ---
> .../media/atomisp/pci/hive_isp_css_common/host/input_system.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> index 8e085dda0c18..5d088d6fb01f 100644
> --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> @@ -1646,6 +1646,7 @@ static input_system_err_t input_system_configure_channel_sensor(
> default:
> return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED;
> }
> + return status;


You're working against a very old tree. This was fixed over a month
ago.

> }

regards,
dan carpenter