2021-09-04 23:35:05

by Randy Dunlap

Subject: [PATCH] media: i2c: ths8200 needs V4L2_ASYNC

Fix the build errors reported by the kernel test robot by
selecting V4L2_ASYNC:

mips-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_remove':
ths8200.c:(.text+0x1ec): undefined reference to `v4l2_async_unregister_subdev'
mips-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_probe':
ths8200.c:(.text+0x404): undefined reference to `v4l2_async_register_subdev'

Fixes: ed29f89497006 ("media: i2c: ths8200: support asynchronous probing")
Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: kernel test robot <[email protected]>
Cc: "Lad, Prabhakar" <[email protected]>
Cc: Hans Verkuil <[email protected]>
Cc: Sakari Ailus <[email protected]>
Cc: Ezequiel Garcia <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: [email protected]
---
drivers/media/i2c/Kconfig | 1 +
1 file changed, 1 insertion(+)

--- linux-next-20210903.orig/drivers/media/i2c/Kconfig
+++ linux-next-20210903/drivers/media/i2c/Kconfig
@@ -597,6 +597,7 @@ config VIDEO_AK881X
config VIDEO_THS8200
tristate "Texas Instruments THS8200 video encoder"
depends on VIDEO_V4L2 && I2C
+ select V4L2_ASYNC
help
Support for the Texas Instruments THS8200 video encoder.

2021-09-05 21:52:32

by Lad, Prabhakar

Subject: Re: [PATCH] media: i2c: ths8200 needs V4L2_ASYNC

Hi Randy,

Thank you for the patch.

On Sun, Sep 5, 2021 at 12:28 AM Randy Dunlap <[email protected]> wrote:
>
> Fix the build errors reported by the kernel test robot by
> selecting V4L2_ASYNC:
>
> mips-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_remove':
> ths8200.c:(.text+0x1ec): undefined reference to `v4l2_async_unregister_subdev'
> mips-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_probe':
> ths8200.c:(.text+0x404): undefined reference to `v4l2_async_register_subdev'
>
> Fixes: ed29f89497006 ("media: i2c: ths8200: support asynchronous probing")
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Cc: "Lad, Prabhakar" <[email protected]>
> Cc: Hans Verkuil <[email protected]>
> Cc: Sakari Ailus <[email protected]>
> Cc: Ezequiel Garcia <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>
> Cc: [email protected]
> ---
> drivers/media/i2c/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Lad Prabhakar <[email protected]>

Cheers,
Prabhakar

> --- linux-next-20210903.orig/drivers/media/i2c/Kconfig
> +++ linux-next-20210903/drivers/media/i2c/Kconfig
> @@ -597,6 +597,7 @@ config VIDEO_AK881X
> config VIDEO_THS8200
> tristate "Texas Instruments THS8200 video encoder"
> depends on VIDEO_V4L2 && I2C
> + select V4L2_ASYNC
> help
> Support for the Texas Instruments THS8200 video encoder.
>

2021-09-06 08:49:19

by Sakari Ailus

Subject: Re: [PATCH] media: i2c: ths8200 needs V4L2_ASYNC

On Sat, Sep 04, 2021 at 04:28:08PM -0700, Randy Dunlap wrote:
> Fix the build errors reported by the kernel test robot by
> selecting V4L2_ASYNC:
>
> mips-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_remove':
> ths8200.c:(.text+0x1ec): undefined reference to `v4l2_async_unregister_subdev'
> mips-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_probe':
> ths8200.c:(.text+0x404): undefined reference to `v4l2_async_register_subdev'
>
> Fixes: ed29f89497006 ("media: i2c: ths8200: support asynchronous probing")
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Cc: "Lad, Prabhakar" <[email protected]>
> Cc: Hans Verkuil <[email protected]>
> Cc: Sakari Ailus <[email protected]>
> Cc: Ezequiel Garcia <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>
> Cc: [email protected]

Acked-by: Sakari Ailus <[email protected]>

--
Sakari Ailus