2021-09-08 09:38:26

by Bixuan Cui

Subject: [PATCH -next] dmaengine: idxd: Use list_move_tail instead of list_del/list_add_tail

Using list_move_tail() instead of list_del() + list_add_tail()

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Bixuan Cui <[email protected]>
---
drivers/dma/idxd/irq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c
index ca88fa7a328e..79fcfc4883e4 100644
--- a/drivers/dma/idxd/irq.c
+++ b/drivers/dma/idxd/irq.c
@@ -221,8 +221,7 @@ static void irq_process_work_list(struct idxd_irq_entry *irq_entry)

list_for_each_entry_safe(desc, n, &irq_entry->work_list, list) {
if (desc->completion->status) {
- list_del(&desc->list);
- list_add_tail(&desc->list, &flist);
+ list_move_tail(&desc->list, &flist);
}
}

--
2.17.1

2021-09-08 18:14:15

by Dave Jiang

Subject: Re: [PATCH -next] dmaengine: idxd: Use list_move_tail instead of list_del/list_add_tail

On 9/8/2021 2:28 AM, Bixuan Cui wrote:
> Using list_move_tail() instead of list_del() + list_add_tail()
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Bixuan Cui <[email protected]>

Thanks!

Acked-by: Dave Jiang <[email protected]>


> ---
> drivers/dma/idxd/irq.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c
> index ca88fa7a328e..79fcfc4883e4 100644
> --- a/drivers/dma/idxd/irq.c
> +++ b/drivers/dma/idxd/irq.c
> @@ -221,8 +221,7 @@ static void irq_process_work_list(struct idxd_irq_entry *irq_entry)
>
> list_for_each_entry_safe(desc, n, &irq_entry->work_list, list) {
> if (desc->completion->status) {
> - list_del(&desc->list);
> - list_add_tail(&desc->list, &flist);
> + list_move_tail(&desc->list, &flist);
> }
> }
>

2021-10-25 10:45:34

by Vinod Koul

Subject: Re: [PATCH -next] dmaengine: idxd: Use list_move_tail instead of list_del/list_add_tail

On 08-09-21, 17:28, Bixuan Cui wrote:
> Using list_move_tail() instead of list_del() + list_add_tail()

Applied, thanks

--
~Vinod