2021-09-08 10:58:04

by Cai,Huoqing

Subject: [PATCH] iio: dac: stm32-dac: Make use of the helper function devm_platform_ioremap_resource()

Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately

Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/iio/dac/stm32-dac-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/iio/dac/stm32-dac-core.c b/drivers/iio/dac/stm32-dac-core.c
index 906436780347..9a6a68b11b2a 100644
--- a/drivers/iio/dac/stm32-dac-core.c
+++ b/drivers/iio/dac/stm32-dac-core.c
@@ -90,7 +90,6 @@ static int stm32_dac_probe(struct platform_device *pdev)
const struct stm32_dac_cfg *cfg;
struct stm32_dac_priv *priv;
struct regmap *regmap;
- struct resource *res;
void __iomem *mmio;
struct reset_control *rst;
int ret;
@@ -106,8 +105,7 @@ static int stm32_dac_probe(struct platform_device *pdev)
cfg = (const struct stm32_dac_cfg *)
of_match_device(dev->driver->of_match_table, dev)->data;

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- mmio = devm_ioremap_resource(dev, res);
+ mmio = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(mmio))
return PTR_ERR(mmio);

--
2.25.1

2021-09-19 23:00:37

by Jonathan Cameron

Subject: Re: [PATCH] iio: dac: stm32-dac: Make use of the helper function devm_platform_ioremap_resource()

On Wed, 8 Sep 2021 18:56:38 +0800
Cai Huoqing <[email protected]> wrote:

> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <[email protected]>

Applied to the togreg branch of iio.git and pushed out as testing for 0-day
to see if it can find any problems that we missed.

Thanks,

Jonathan

> ---
> drivers/iio/dac/stm32-dac-core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/dac/stm32-dac-core.c b/drivers/iio/dac/stm32-dac-core.c
> index 906436780347..9a6a68b11b2a 100644
> --- a/drivers/iio/dac/stm32-dac-core.c
> +++ b/drivers/iio/dac/stm32-dac-core.c
> @@ -90,7 +90,6 @@ static int stm32_dac_probe(struct platform_device *pdev)
> const struct stm32_dac_cfg *cfg;
> struct stm32_dac_priv *priv;
> struct regmap *regmap;
> - struct resource *res;
> void __iomem *mmio;
> struct reset_control *rst;
> int ret;
> @@ -106,8 +105,7 @@ static int stm32_dac_probe(struct platform_device *pdev)
> cfg = (const struct stm32_dac_cfg *)
> of_match_device(dev->driver->of_match_table, dev)->data;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mmio = devm_ioremap_resource(dev, res);
> + mmio = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mmio))
> return PTR_ERR(mmio);
>